From: Greg KH <gregkh@linuxfoundation.org>
To: Keerthimai Janarthanan <keerthimaipb@gmail.com>
Cc: devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] staging :keucr:scsiglue.c : fixed a macros should not be colon terminated issue
Date: Tue, 4 Mar 2014 17:10:54 -0800 [thread overview]
Message-ID: <20140305011054.GA10990@kroah.com> (raw)
In-Reply-To: <1393764677-4709-1-git-send-email-keerthimaipb@gmail.com>
On Sun, Mar 02, 2014 at 06:21:16PM +0530, Keerthimai Janarthanan wrote:
> fixed a coding style issue.
>
> Signed-off-by: Keerthimai Janarthanan <keerthimaipb@gmail.com>
> ---
> drivers/staging/keucr/scsiglue.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/keucr/scsiglue.c b/drivers/staging/keucr/scsiglue.c
> index ac3d34d..fce19a4 100644
> --- a/drivers/staging/keucr/scsiglue.c
> +++ b/drivers/staging/keucr/scsiglue.c
> @@ -277,7 +277,7 @@ static int show_info(struct seq_file *m, struct Scsi_Host *host)
> do { \
> if (us->fflags & value) \
> SPRINTF(" " #name); \
> - } while (0);
> + } while (0)
You just broke the build.
Please ALWAYS test your patches, don't break someone else's build with
broken patches...
Please be more careful.
next prev parent reply other threads:[~2014-03-05 1:09 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-02 12:51 [PATCH 2/2] staging :keucr:scsiglue.c : fixed a macros should not be colon terminated issue Keerthimai Janarthanan
2014-03-05 1:10 ` Greg KH [this message]
2014-03-05 1:44 ` Joe Perches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140305011054.GA10990@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=devel@driverdev.osuosl.org \
--cc=keerthimaipb@gmail.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox