[PATCH 2/2] staging :keucr:scsiglue.c : fixed a macros should not be colon terminated issue

[PATCH 2/2] staging :keucr:scsiglue.c : fixed a macros should not be colon terminated issue

[Keerthimai Janarthanan]

fixed a coding style issue.

Signed-off-by: Keerthimai Janarthanan <keerthimaipb@gmail.com>
---
 drivers/staging/keucr/scsiglue.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/staging/keucr/scsiglue.c b/drivers/staging/keucr/scsiglue.c
index ac3d34d..fce19a4 100644
--- a/drivers/staging/keucr/scsiglue.c
+++ b/drivers/staging/keucr/scsiglue.c
@@ -277,7 +277,7 @@ static int show_info(struct seq_file *m, struct Scsi_Host *host)
 	do { \
 		if (us->fflags & value) \
 			SPRINTF(" " #name); \
-	} while (0);
+	} while (0)
 US_DO_ALL_FLAGS
 #undef US_FLAG
 	seq_putc(m, '\n');
-- 
1.8.3.2

Re: [PATCH 2/2] staging :keucr:scsiglue.c : fixed a macros should not be colon terminated issue

[Greg KH]

On Sun, Mar 02, 2014 at 06:21:16PM +0530, Keerthimai Janarthanan wrote:
> fixed a coding style issue.
> 
> Signed-off-by: Keerthimai Janarthanan <keerthimaipb@gmail.com>
> ---
>  drivers/staging/keucr/scsiglue.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/staging/keucr/scsiglue.c b/drivers/staging/keucr/scsiglue.c
> index ac3d34d..fce19a4 100644
> --- a/drivers/staging/keucr/scsiglue.c
> +++ b/drivers/staging/keucr/scsiglue.c
> @@ -277,7 +277,7 @@ static int show_info(struct seq_file *m, struct Scsi_Host *host)
>  	do { \
>  		if (us->fflags & value) \
>  			SPRINTF(" " #name); \
> -	} while (0);
> +	} while (0)

You just broke the build.

Please ALWAYS test your patches, don't break someone else's build with
broken patches...

Please be more careful.

Re: [PATCH 2/2] staging :keucr:scsiglue.c : fixed a macros should not be colon terminated issue

[Joe Perches]

On Tue, 2014-03-04 at 17:10 -0800, Greg KH wrote:
> On Sun, Mar 02, 2014 at 06:21:16PM +0530, Keerthimai Janarthanan wrote:
> > fixed a coding style issue.
[]
> > diff --git a/drivers/staging/keucr/scsiglue.c b/drivers/staging/keucr/scsiglue.c
[]
> > @@ -277,7 +277,7 @@ static int show_info(struct seq_file *m, struct Scsi_Host *host)
> >  	do { \
> >  		if (us->fflags & value) \
> >  			SPRINTF(" " #name); \
> > -	} while (0);
> > +	} while (0)
> 
> You just broke the build.
> 
> Please ALWAYS test your patches, don't break someone else's build with
> broken patches...
> 
> Please be more careful.

Thanks Greg.

Keerthimai, a possibly "better" fix would be to add a
do { ... } while (0) guard and semicolons to the relatively
ugly US_DO_ALL_FLAGS macro and US_FLAG uses in
include/linux/usb_usual.h

include/linux/usb_usual.h:#define US_DO_ALL_FLAGS                                               \
include/linux/usb_usual.h-      US_FLAG(SINGLE_LUN,     0x00000001)                     \
include/linux/usb_usual.h-              /* allow access to only LUN 0 */                \
include/linux/usb_usual.h-      US_FLAG(NEED_OVERRIDE,  0x00000002)                     \
include/linux/usb_usual.h-              /* unusual_devs entry is necessary */           \
...

and then add a semicolon to the uses of US_DO_ALL_FLAGS
and then remove a semicolon as above.