From: Mark Brown <broonie@kernel.org>
To: "Li.Xiubo@freescale.com" <Li.Xiubo@freescale.com>
Cc: Lars-Peter Clausen <lars@metafoo.de>,
"lgirdwood@gmail.com" <lgirdwood@gmail.com>,
"Fabio.Estevam@freescale.com" <Fabio.Estevam@freescale.com>,
"moinejf@free.fr" <moinejf@free.fr>,
"alsa-devel@alsa-project.org" <alsa-devel@alsa-project.org>,
"kuninori.morimoto.gx@renesas.com"
<kuninori.morimoto.gx@renesas.com>,
"tiwai@suse.de" <tiwai@suse.de>,
"s.hauer@pengutronix.de" <s.hauer@pengutronix.de>,
"timur@tabi.org" <timur@tabi.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"denis@eukrea.com" <denis@eukrea.com>,
"guangyu.chen@freescale.com" <guangyu.chen@freescale.com>,
"mpa@pengutronix.de" <mpa@pengutronix.de>,
"shawn.guo@linaro.org" <shawn.guo@linaro.org>
Subject: Re: [alsa-devel] [PATCH 01/10] ASoC: core: Add snd_soc_dai_set_tdm_slot_xlate().
Date: Wed, 5 Mar 2014 14:30:15 +0800 [thread overview]
Message-ID: <20140305063015.GA1704@sirena.org.uk> (raw)
In-Reply-To: <6991b4aaf2a34f8180b24f7a2ae8355a@BY2PR03MB505.namprd03.prod.outlook.com>
[-- Attachment #1: Type: text/plain, Size: 881 bytes --]
On Wed, Mar 05, 2014 at 03:55:50AM +0000, Li.Xiubo@freescale.com wrote:
> This adds the function of snd_soc_dai_set_tdm_slot_xlate, which is almost
> One new signature of snd_soc_dai_set_tdm_slot discarding the mask
> Parameters, which could be generated by itself.
Right, so that's not a bad thing but the _xlate() naming is confusing -
Lars' point was that if a function is called _xlate() it would usually
be an operation used as part of DT parsing, not something called from
non-DT code. The new interface is probably a good thing but needs a
different name (perhaps _simple or something?) or we need to rename the
old one out of the way (it's slightly less flexible so we probably don't
want to remove it totally).
> And I want to provide one standard method for the drivers who are parsing
> The TDM information from the DT node.
This is a good goal.
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
next prev parent reply other threads:[~2014-03-05 7:08 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-26 3:59 [PATCH 00/10] Simplify the code of TDM slot setting Xiubo Li
2014-02-26 3:59 ` [PATCH 01/10] ASoC: core: Add snd_soc_dai_set_tdm_slot_xlate() Xiubo Li
2014-03-01 13:19 ` [alsa-devel] " Lars-Peter Clausen
2014-03-05 3:39 ` Mark Brown
2014-03-05 3:55 ` Li.Xiubo
2014-03-05 6:30 ` Mark Brown [this message]
2014-02-26 3:59 ` [PATCH 02/10] ASoC: fsl-utils: Add fsl_asoc_of_xlate_tdm_slot_mask() support Xiubo Li
2014-02-26 3:59 ` [PATCH 03/10] ASoC: fsl-esai: Add .of_xlate_tdm_slot_mask() support Xiubo Li
2014-02-26 3:59 ` [PATCH 04/10] ASoC: fsl-ssi: " Xiubo Li
2014-02-26 3:59 ` [PATCH 05/10] ASoC: imx-ssi: " Xiubo Li
2014-02-26 3:59 ` [PATCH 06/10] ASoC: simple-card: Use snd_soc_dai_set_tdm_slot_xlate() Xiubo Li
2014-02-26 3:59 ` [PATCH 07/10] ASoC: blackfin: bf5xx-ad1836: " Xiubo Li
2014-02-26 3:59 ` [PATCH 08/10] ASoC: blackfin: bf5xx-ad193x: " Xiubo Li
2014-02-26 3:59 ` [PATCH 09/10] ASoC: fsl: eukrea-tlv320: " Xiubo Li
2014-02-26 3:59 ` [PATCH 10/10] ASoC: fsl: wm1133-ev1: " Xiubo Li
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140305063015.GA1704@sirena.org.uk \
--to=broonie@kernel.org \
--cc=Fabio.Estevam@freescale.com \
--cc=Li.Xiubo@freescale.com \
--cc=alsa-devel@alsa-project.org \
--cc=denis@eukrea.com \
--cc=guangyu.chen@freescale.com \
--cc=kuninori.morimoto.gx@renesas.com \
--cc=lars@metafoo.de \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=moinejf@free.fr \
--cc=mpa@pengutronix.de \
--cc=s.hauer@pengutronix.de \
--cc=shawn.guo@linaro.org \
--cc=timur@tabi.org \
--cc=tiwai@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox