Re: [PATCH] EDAC: remove deprecated IRQF_DISABLED

Johannes Thumshirn
2013-10-14T09:56:13Z

On Sun, Oct 13, 2013 at 07:17:57AM +0200, Michael Opdenacker wrote:
> This patch proposes to remove the use of the IRQF_DISABLED flag
>
> It's a NOOP since 2.6.35 and it will be removed one day.
>
> Signed-off-by: Michael Opdenacker <michael.opdenacker@free-electrons.com>
> ---
> drivers/edac/mpc85xx_edac.c | 7 +++----
> drivers/edac/mv64x60_edac.c | 8 ++++----
> drivers/edac/ppc4xx_edac.c | 4 ++--
> 3 files changed, 9 insertions(+), 10 deletions(-)
>
> diff --git a/drivers/edac/mpc85xx_edac.c b/drivers/edac/mpc85xx_edac.c
> index 3eb32f6..7785807 100644
> --- a/drivers/edac/mpc85xx_edac.c
> +++ b/drivers/edac/mpc85xx_edac.c
> @@ -297,7 +297,7 @@ int mpc85xx_pci_err_probe(struct platform_device *op)
> if (edac_op_state == EDAC_OPSTATE_INT) {
> pdata->irq = irq_of_parse_and_map(op->dev.of_node, 0);
> res = devm_request_irq(&op->dev, pdata->irq,
> - mpc85xx_pci_isr, IRQF_DISABLED,
> + mpc85xx_pci_isr, 0,
> "[EDAC] PCI err", pci);
> if (res < 0) {
> printk(KERN_ERR
> @@ -579,7 +579,7 @@ static int mpc85xx_l2_err_probe(struct platform_device *op)
> if (edac_op_state == EDAC_OPSTATE_INT) {
> pdata->irq = irq_of_parse_and_map(op->dev.of_node, 0);
> res = devm_request_irq(&op->dev, pdata->irq,
> - mpc85xx_l2_isr, IRQF_DISABLED,
> + mpc85xx_l2_isr, 0,
> "[EDAC] L2 err", edac_dev);
> if (res < 0) {
> printk(KERN_ERR
> @@ -1078,8 +1078,7 @@ static int mpc85xx_mc_err_probe(struct platform_device *op)
> /* register interrupts */
> pdata->irq = irq_of_parse_and_map(op->dev.of_node, 0);
> res = devm_request_irq(&op->dev, pdata->irq,
> - mpc85xx_mc_isr,
> - IRQF_DISABLED | IRQF_SHARED,
> + mpc85xx_mc_isr, IRQF_SHARED,
> "[EDAC] MC err", mci);
> if (res < 0) {
> printk(KERN_ERR "%s: Unable to request irq %d for "

Hi Michael,

mpc85xx_edac has them already removed in the version that is going into 3.13.

Sorry for the inconvenience. I'll set up a public tree at my github repo, so
everyone can see the current mpc85xx_edac state.

Byte,
Johannes