From: Tyler Hicks <tyhicks@canonical.com>
To: Dave Hansen <dave.hansen@intel.com>
Cc: ecryptfs@vger.kernel.org, LKML <linux-kernel@vger.kernel.org>
Subject: Re: ecryptfs log spew from EINTR
Date: Wed, 5 Mar 2014 11:53:16 -0600 [thread overview]
Message-ID: <20140305175316.GA20812@boyd> (raw)
In-Reply-To: <53175BB0.1020107@intel.com>
[-- Attachment #1: Type: text/plain, Size: 1024 bytes --]
On 2014-03-05 09:15:28, Dave Hansen wrote:
> I have a little program that uses mmap() to copy files. Essentially:
>
> addr1 = mmap(fd1);
> addr2 = mmap(fd2);
> memcpy(addr1, addr2, len);
>
> If these files are on ecryptfs and I interrupt the memcpy() with ^C, I
> consistently get this in dmesg:
>
> ecryptfs_decrypt_page: Error attempting to read lower page; rc = [-4]
> ecryptfs_readpage: Error decrypting page; rc = [-4]
>
> -4 is, of course -EINTR because of the ^C. Should we be suppressing the
> message when we see EINTR?
Yes. In fact, eCryptfs shouldn't print a KERN_ERR message at all in this
situation. KERN_DEBUG at most. eCryptfs is too chatty in many cases.
I'd like to switch over to the pr_* functions and downgrade many log
messages to pr_debug() at that time.
Tyler
> --
> To unsubscribe from this list: send the line "unsubscribe ecryptfs" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
prev parent reply other threads:[~2014-03-05 17:53 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-05 17:15 ecryptfs log spew from EINTR Dave Hansen
2014-03-05 17:53 ` Tyler Hicks [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140305175316.GA20812@boyd \
--to=tyhicks@canonical.com \
--cc=dave.hansen@intel.com \
--cc=ecryptfs@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox