From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Cc: Joe Perches <joe@perches.com>,
devel@driverdev.osuosl.org, Paul Bolle <pebolle@tiscali.nl>,
linux-kernel@vger.kernel.org,
Mauro Carvalho Chehab <m.chehab@samsung.com>,
linux-media@vger.kernel.org
Subject: Re: [PATCH v2] [media] v4l: omap4iss: Add DEBUG compiler flag
Date: Wed, 5 Mar 2014 20:45:29 -0800 [thread overview]
Message-ID: <20140306044529.GA6466@kroah.com> (raw)
In-Reply-To: <2136780.FIdBGb725A@avalon>
On Thu, Mar 06, 2014 at 01:48:29AM +0100, Laurent Pinchart wrote:
> Hi Joe,
>
> On Wednesday 05 March 2014 16:28:03 Joe Perches wrote:
> > On Thu, 2014-03-06 at 00:50 +0100, Laurent Pinchart wrote:
> > > Please note that -DDEBUG is equivalent to '#define DEBUG', not to '#define
> > > CONFIG_DEBUG'. 'DEBUG' needs to be defined for dev_dbg() to have any
> > > effect.
> >
> > Not quite. If CONFIG_DYNAMIC_DEBUG is set, these
> > dev_dbg statements are compiled in but not by default
> > set to emit output. Output can be enabled by using
> > dynamic_debug controls like:
> >
> > # echo -n 'file omap4iss/* +p' > <debugfs>/dynamic_debug/control
> >
> > See Documentation/dynamic-debug-howto.txt for more details.
>
> Thank you for the additional information.
>
> Would you recommend to drop driver-specific Kconfig options related to
> debugging and use CONFIG_DYNAMIC_DEBUG instead ?
Yes, please do that, no one wants to rebuild drivers and subsystems with
different options just for debugging.
thanks,
greg k-h
next prev parent reply other threads:[~2014-03-06 4:45 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-09 15:09 [PATCH] [media] v4l: omap4iss: Remove VIDEO_OMAP4_DEBUG Paul Bolle
2014-02-10 14:13 ` Laurent Pinchart
2014-02-10 15:13 ` Paul Bolle
2014-02-10 15:29 ` Laurent Pinchart
2014-02-11 11:17 ` [PATCH v2] [media] v4l: omap4iss: Add DEBUG compiler flag Paul Bolle
2014-02-11 12:38 ` Laurent Pinchart
2014-03-05 20:10 ` Mauro Carvalho Chehab
2014-03-05 23:50 ` Laurent Pinchart
2014-03-06 0:28 ` Joe Perches
2014-03-06 0:48 ` Laurent Pinchart
2014-03-06 1:00 ` Joe Perches
2014-03-06 1:27 ` Laurent Pinchart
2014-03-06 1:35 ` Joe Perches
2014-03-06 1:52 ` Laurent Pinchart
2014-03-06 3:25 ` Joe Perches
2014-03-06 10:55 ` Laurent Pinchart
2014-03-06 16:47 ` Joe Perches
2014-03-06 4:45 ` Greg Kroah-Hartman [this message]
2014-03-06 10:23 ` Paul Bolle
2014-03-06 11:00 ` Laurent Pinchart
2014-03-06 11:59 ` Mauro Carvalho Chehab
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140306044529.GA6466@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=devel@driverdev.osuosl.org \
--cc=joe@perches.com \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=m.chehab@samsung.com \
--cc=pebolle@tiscali.nl \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox