From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751492AbaCFJLa (ORCPT ); Thu, 6 Mar 2014 04:11:30 -0500 Received: from merlin.infradead.org ([205.233.59.134]:48393 "EHLO merlin.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751136AbaCFJLN (ORCPT ); Thu, 6 Mar 2014 04:11:13 -0500 Date: Thu, 6 Mar 2014 10:11:02 +0100 From: Peter Zijlstra To: Tony Lu Cc: Paul Mackerras , Ingo Molnar , Arnaldo Carvalho de Melo , Chris Metcalf , "linux-kernel@vger.kernel.org" Subject: Re: [PATCH 1/4] tile: Add support for handling PMC hardware Message-ID: <20140306091102.GG9987@twins.programming.kicks-ass.net> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.21 (2012-12-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Mar 06, 2014 at 06:13:48AM +0000, Tony Lu wrote: The changelogs are all very sparse. But in general the stuff looks to have the right shape. It looks like you do software NMIs with interrupt priority levels; which is a perfectly fine way, other archs do the same. One thing I didn't spot is a tile irq_work implementation; perf likes to have one.