Re: [PATCH v6 4/8] of: Reduce indentation in of_graph_get_next_endpoint

Philipp Zabel
2014-03-07T17:41:14Z

Hi Laurent,

Am Freitag, den 07.03.2014, 01:12 +0100 schrieb Laurent Pinchart:
> Hi Philipp,
>
> Thank you for the patch.
>
> I've submitted a fix for the of_graph_get_next_endpoint() function, but it
> hasn't been applied yet due to the patch series that contained it needing more
> work.
>
> The patch is available at https://patchwork.linuxtv.org/patch/21946/. I can
> rebase it on top of this series, but I still wanted to let you know about it
> in case you would like to integrate it.

Thank you for the pointer. A pity about the timing, this will mostly
revert my indentation patch. I'd be glad if you could rebase on top of
the merged series.

While we look at of_graph_get_next_endpoint(), could you explain the
reason behind the extra reference count increase on the prev node:
/*
* Avoid dropping prev node refcount to 0 when getting the next
* child below.
*/
of_node_get(prev);
This unfortunately makes using the function in for_each style macros a
hassle. If that part wasn't there and all users that want to keep using
prev after the call were expected to increase refcount themselves,
we could have a
#define of_graph_for_each_endpoint(parent, endpoint) \
for (endpoint = of_graph_get_next_endpoint(parent, NULL); \
endpoint != NULL; \
endpoint = of_graph_get_next_endpoint(parent, endpoint))

regards
Philipp