public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <gregkh@linuxfoundation.org>
To: "xinhui.pan" <xinhuix.pan@intel.com>
Cc: linux-kernel@vger.kernel.org, stern@rowland.harvard.edu,
	sarah.a.sharp@linux.intel.com, dan.j.williams@intel.com,
	burzalodowa@gmail.com, yanmin_zhang@linux.intel.com
Subject: Re: [PATCH] usb/core/hub.c: return immediately when hub_port_init hits timedout
Date: Thu, 6 Mar 2014 22:47:18 -0800	[thread overview]
Message-ID: <20140307064718.GA20065@kroah.com> (raw)
In-Reply-To: <53196414.8090703@intel.com>

On Fri, Mar 07, 2014 at 02:15:48PM +0800, xinhui.pan wrote:
> From: "xinhui.pan" <xinhuiX.pan@intel.com>

I doubt your name as a "." in it, right?

> some devices go crasy, we can't resume it even after reset.

I don't understand, what do you mean by this?  What exactly does a
device do, and why does it do it?  And what happens?

> This case will cause timeout again and again. What is worse, if there
> is a watchdog, panic will be generated as timer expires.

A watchdog where?

> To prevent this, we just return -ENODEV immediately. Later it will be
> re-enumerated.

What will cause it to be re-enumerated?

confused,

greg k-h

  reply	other threads:[~2014-03-07  6:46 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-03-07  6:15 [PATCH] usb/core/hub.c: return immediately when hub_port_init hits timedout xinhui.pan
2014-03-07  6:47 ` Greg KH [this message]
2014-03-07  7:32   ` xinhui.pan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140307064718.GA20065@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=burzalodowa@gmail.com \
    --cc=dan.j.williams@intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=sarah.a.sharp@linux.intel.com \
    --cc=stern@rowland.harvard.edu \
    --cc=xinhuix.pan@intel.com \
    --cc=yanmin_zhang@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox