From: Dan Carpenter <dan.carpenter@oracle.com>
To: "Wang, Xiaoming" <xiaoming.wang@intel.com>
Cc: gregkh@linuxfoundation.org, valentina.manea.m@gmail.com,
standby24x7@gmail.com, devel@driverdev.osuosl.org,
chuansheng.liu@intel.com, dongxing.zhang@intel.com,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] [staging][r8188eu]: memory leak in rtw_free_cmd_obj if command is (_Set_Drv_Extra)
Date: Fri, 7 Mar 2014 11:04:11 +0300 [thread overview]
Message-ID: <20140307080411.GB29018@mwanda> (raw)
In-Reply-To: <1394222494.26112.32.camel@wxm-ubuntu>
On Fri, Mar 07, 2014 at 03:01:34PM -0500, Wang, Xiaoming wrote:
> pcmd->parmbuf->pbuf has been allocated if command is GEN_CMD_CODE(_Set_Drv_Extra),
> and it enqueued by rtw_enqueue_cmd. rtw_cmd_thread dequeue pcmd by rtw_dequeue_cmd.
> The memory leak happened on this branch "if( _FAIL == rtw_cmd_filter(pcmdpriv, pcmd) )"
> which goto post_process directly against freeing pcmd->parmbuf->pbuf in
> rtw_drvextra_cmd_hdl which is the cmd_hdl if command is (_Set_Drv_Extra).
> This patch free pcmd->parmbuf->pbuf on forgotten branch to avoid memory leak.
>
> Signed-off-by: Zhang Dongxing <dongxing.zhang@intel.com>
> Signed-off-by: xiaoming wang <xiaoming.wang@intel.com>
This code looks completely different in linux-next. Please redo on top
of linux-next if it's still needed.
regards,
dan carpenter
next prev parent reply other threads:[~2014-03-07 8:04 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-07 20:01 [PATCH] [staging][r8188eu]: memory leak in rtw_free_cmd_obj if command is (_Set_Drv_Extra) Wang, Xiaoming
2014-03-07 8:04 ` Dan Carpenter [this message]
-- strict thread matches above, loose matches on Subject: below --
2014-03-10 15:37 Wang, Xiaoming
2014-03-10 1:44 ` Liu, Chuansheng
2014-03-17 21:38 ` Greg KH
2014-03-18 14:25 Wang, Xiaoming
2014-03-18 20:03 ` [PATCH] staging: r8188eu: " Greg KH
2014-03-26 8:53 ` [PATCH] [staging][r8188eu]: " Dan Carpenter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140307080411.GB29018@mwanda \
--to=dan.carpenter@oracle.com \
--cc=chuansheng.liu@intel.com \
--cc=devel@driverdev.osuosl.org \
--cc=dongxing.zhang@intel.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=standby24x7@gmail.com \
--cc=valentina.manea.m@gmail.com \
--cc=xiaoming.wang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox