From: Alessandro Zummo <a.zummo@towertech.it>
To: "Opensource [Steve Twiss]" <stwiss.opensource@diasemi.com>
Cc: David Dajun Chen <david.chen@diasemi.com>,
LKML <linux-kernel@vger.kernel.org>,
RTC linux <rtc-linux@googlegroups.com>
Subject: Re: [PATCH V1 2/2] rtc: da9063: RTC driver
Date: Fri, 7 Mar 2014 10:33:10 +0100 [thread overview]
Message-ID: <20140307103310.3444cef6@linux.lan.towertech.it> (raw)
In-Reply-To: <93327cde91bcaef9a467adc6c7b34c3231d9e1e7.1394124002.git.stwiss.opensource@diasemi.com>
On Thu, 6 Mar 2014 16:40:02 +0000
"Opensource [Steve Twiss]" <stwiss.opensource@diasemi.com> wrote:
> Change History:
>
> Changes made to this driver since previous RFC V1
> Comments by Alessandro Zummo
> - http://www.kernelhub.org/?p=2&msg=426327
> - Use return PTR_ERR(rtc->rtc_dev); instead of goto err; return err.
> - Request the interrupt before the RTC device is registered with the
> call to devm_rtc_device_register.
Acked-by: Alessandro Zummo <a.zummo@towertech.it>
--
Best regards,
Alessandro Zummo,
Tower Technologies - Torino, Italy
http://www.towertech.it
next prev parent reply other threads:[~2014-03-07 9:33 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-06 16:40 [PATCH V1 0/2] da9063: Support for RTC and register definition updates Opensource [Steve Twiss]
2014-03-06 16:40 ` [PATCH V1 1/2] mfd: da9063: Upgrade of register definitions to support production silicon Opensource [Steve Twiss]
2014-03-07 3:32 ` Lee Jones
2014-03-07 9:44 ` Opensource [Steve Twiss]
2014-03-10 14:02 ` Lee Jones
2014-03-10 15:50 ` Opensource [Steve Twiss]
2014-03-10 16:27 ` Lee Jones
2014-03-06 16:40 ` [PATCH V1 2/2] rtc: da9063: RTC driver Opensource [Steve Twiss]
2014-03-07 9:33 ` Alessandro Zummo [this message]
2014-03-07 9:50 ` Opensource [Steve Twiss]
2014-04-11 11:45 ` Opensource [Steve Twiss]
2014-04-11 15:32 ` Alessandro Zummo
2014-03-11 12:27 ` [RESEND] " Lee Jones
2014-03-11 13:21 ` Opensource [Steve Twiss]
2014-03-21 14:17 ` Opensource [Steve Twiss]
2014-03-25 16:46 ` Opensource [Steve Twiss]
2014-03-26 7:52 ` Lee Jones
2014-03-26 8:11 ` Opensource [Steve Twiss]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140307103310.3444cef6@linux.lan.towertech.it \
--to=a.zummo@towertech.it \
--cc=david.chen@diasemi.com \
--cc=linux-kernel@vger.kernel.org \
--cc=rtc-linux@googlegroups.com \
--cc=stwiss.opensource@diasemi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox