From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753327AbaCGNpI (ORCPT ); Fri, 7 Mar 2014 08:45:08 -0500 Received: from top.free-electrons.com ([176.31.233.9]:38737 "EHLO mail.free-electrons.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752232AbaCGNpE (ORCPT ); Fri, 7 Mar 2014 08:45:04 -0500 Date: Fri, 7 Mar 2014 14:44:12 +0100 From: Maxime Ripard To: Wolfram Sang Cc: Chen-Yu Tsai , linux-sunxi , linux-kernel , zhuzhenhua@allwinnertech.com, kevin.z.m.zh@gmail.com, sunny@allwinnertech.com, shuge@allwinnertech.com, linux-arm-kernel , linux-i2c@vger.kernel.org, Philipp Zabel Subject: Re: [linux-sunxi] Re: [PATCH v3 1/5] i2c: mv64xxx: Add reset deassert call Message-ID: <20140307134412.GR607@lukather> References: <1393950521-4173-1-git-send-email-maxime.ripard@free-electrons.com> <1393950521-4173-2-git-send-email-maxime.ripard@free-electrons.com> <20140307095222.GG21483@n2100.arm.linux.org.uk> <20140307100751.GN607@lukather> <20140307103433.GH21483@n2100.arm.linux.org.uk> <20140307111858.GB12274@katana> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="DHnhIMemoiGGMQp1" Content-Disposition: inline In-Reply-To: <20140307111858.GB12274@katana> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --DHnhIMemoiGGMQp1 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Hi, On Fri, Mar 07, 2014 at 12:18:58PM +0100, Wolfram Sang wrote: >=20 > > > Since RESET_CONTROLLER is not required for those platforms, it really > > > should be optional - and I think the real fix is for the reset contro= ller > > > support to provide stub functions. > >=20 > > Philipp Zabel suggested that adding a _optional variant that provides s= tubs > > and doesn't depend on RESET_CONTROLLER is probably better. This keeps t= he > > compile time checks for drivers requiring it. > >=20 > > See: https://lkml.org/lkml/2014/1/10/220 > >=20 > > I ended up dropping my patch though. >=20 > Thanks for the pointer. Well, looks like I need to revert the offending > i2c patches then until this issue is fixed? We can't have > RESET_CONTROLLER (circular dependency) and we can't skip it (build > failures). >=20 I just sent a fix in reply to your mail that should fix the issue without having to revert the patches. Thanks! Maxime --=20 Maxime Ripard, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com --DHnhIMemoiGGMQp1 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.14 (GNU/Linux) iQIcBAEBAgAGBQJTGc0sAAoJEBx+YmzsjxAgFgQP/37xNPl+RtB5VslRlcnXI+KX cOL20b8NpUSGGVQZYfENw8R1pNDR1/P7zcXxLNsiZq6pPiS5LkcF5T4qfaIrP/uG qZ+ibA9RCA/HRu8/wmxtOL8xjWY9adEblQb9vS+YIY3c8z5PsxixUO1YuSGWeTSE Gs6Y7XYkPbU9QsTKYpt19EfIOr6LXg6yTfQC0sVXvZE8qxaVP5rDaQFKm83lpFPq ENrXI3ne/82ZD6DGj0GcoHy5nRDHm/8zbuB8DIfxYeYLHi1OFsP5jB58rsEX2cDp EnaxDZ6WAjAGVwktw9oT28NZ6juNgWEglZvLhOKGYgTH9dpB8JVrtxU/zSIykKM1 OaAUg9xiy+vBwsFxvmK1uO8c0/2e1EAs6I/XA3EIYa1w0lYA4519YBexLlVJiH5I mvbWLCswFv2jp2pICb9WyD3PxLrSbMui+0xp6m8g51syUm7M5hmavhk+z423L1yO DwibCMtfQwR9/H5uFHuoVKw1DMsny71HapFKYdveSg+M8GrfELUDcZEBaa71gbI3 ry7kkQdsGbSYGX3oJgqHLGAiig61kSIoYX1J7ZphlhceZ9QTH0fJ6YFWXrMBn1c7 UAMj3QLmg86Axv8S459u+xCjC4tmpEHToW0HnGLTH7OQanCw2GIcDKUCjLKpdGbA zWCWiK8HFW1omySLiXv3 =Icfr -----END PGP SIGNATURE----- --DHnhIMemoiGGMQp1--