* [PATCH] asm-generic: rwsem: de-PPCify rwsem.h
@ 2014-03-07 15:05 Will Deacon
2014-03-07 16:27 ` Arnd Bergmann
0 siblings, 1 reply; 2+ messages in thread
From: Will Deacon @ 2014-03-07 15:05 UTC (permalink / raw)
To: linux-kernel; +Cc: Will Deacon, Arnd Bergmann
asm-generic/rwsem.h used to live under arch/powerpc. During its
liberation to common code, a few references to its former home where
preserved, in particular the definition of RWSEM_ACTIVE_MASK is
predicated on CONFIG_PPC64.
This patch updates the ifdefs and comments to architecturally neutral
versions.
Cc: Arnd Bergmann <arnd@arndb.de>
Acked-by: Richard Kuo <rkuo@codeaurora.org>
Signed-off-by: Will Deacon <will.deacon@arm.com>
---
Hi Arnd,
Any chance you could queue this for 3.15 please? It means I can easily
move arm64 over to the asm-generic rwsem implementation afterwards.
Cheers,
Will
include/asm-generic/rwsem.h | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/include/asm-generic/rwsem.h b/include/asm-generic/rwsem.h
index bb1e2cdeb9bf..d48bf5a95cc1 100644
--- a/include/asm-generic/rwsem.h
+++ b/include/asm-generic/rwsem.h
@@ -1,5 +1,5 @@
-#ifndef _ASM_POWERPC_RWSEM_H
-#define _ASM_POWERPC_RWSEM_H
+#ifndef _ASM_GENERIC_RWSEM_H
+#define _ASM_GENERIC_RWSEM_H
#ifndef _LINUX_RWSEM_H
#error "Please don't include <asm/rwsem.h> directly, use <linux/rwsem.h> instead."
@@ -8,7 +8,7 @@
#ifdef __KERNEL__
/*
- * R/W semaphores for PPC using the stuff in lib/rwsem.c.
+ * R/W semaphores originally for PPC using the stuff in lib/rwsem.c.
* Adapted largely from include/asm-i386/rwsem.h
* by Paul Mackerras <paulus@samba.org>.
*/
@@ -16,7 +16,7 @@
/*
* the semaphore definition
*/
-#ifdef CONFIG_PPC64
+#ifdef CONFIG_64BIT
# define RWSEM_ACTIVE_MASK 0xffffffffL
#else
# define RWSEM_ACTIVE_MASK 0x0000ffffL
@@ -129,4 +129,4 @@ static inline long rwsem_atomic_update(long delta, struct rw_semaphore *sem)
}
#endif /* __KERNEL__ */
-#endif /* _ASM_POWERPC_RWSEM_H */
+#endif /* _ASM_GENERIC_RWSEM_H */
--
1.8.2.2
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] asm-generic: rwsem: de-PPCify rwsem.h
2014-03-07 15:05 [PATCH] asm-generic: rwsem: de-PPCify rwsem.h Will Deacon
@ 2014-03-07 16:27 ` Arnd Bergmann
0 siblings, 0 replies; 2+ messages in thread
From: Arnd Bergmann @ 2014-03-07 16:27 UTC (permalink / raw)
To: Will Deacon; +Cc: linux-kernel
On Friday 07 March 2014, Will Deacon wrote:
> asm-generic/rwsem.h used to live under arch/powerpc. During its
> liberation to common code, a few references to its former home where
> preserved, in particular the definition of RWSEM_ACTIVE_MASK is
> predicated on CONFIG_PPC64.
>
> This patch updates the ifdefs and comments to architecturally neutral
> versions.
>
> Cc: Arnd Bergmann <arnd@arndb.de>
> Acked-by: Richard Kuo <rkuo@codeaurora.org>
> Signed-off-by: Will Deacon <will.deacon@arm.com>
> ---
>
> Hi Arnd,
>
> Any chance you could queue this for 3.15 please? It means I can easily
> move arm64 over to the asm-generic rwsem implementation afterwards.
>
Acked-by: Arnd Bergmann <arnd@arndb.de>
I don't expect any conflicts, so just put it in the arm64 tree along with
the patch to use it.
Arnd
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2014-03-07 16:28 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-03-07 15:05 [PATCH] asm-generic: rwsem: de-PPCify rwsem.h Will Deacon
2014-03-07 16:27 ` Arnd Bergmann
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox