From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1753594AbaCGWH0 (ORCPT <rfc822;w@1wt.eu>);
	Fri, 7 Mar 2014 17:07:26 -0500
Received: from mx1.redhat.com ([209.132.183.28]:38798 "EHLO mx1.redhat.com"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1752748AbaCGWHY (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
	Fri, 7 Mar 2014 17:07:24 -0500
Date: Fri, 7 Mar 2014 17:06:55 -0500
From: Dave Jones <davej@redhat.com>
To: Borislav Petkov <bp@alien8.de>
Cc: "H. Peter Anvin" <hpa@linux.intel.com>,
        Fengguang Wu <fengguang.wu@intel.com>, Ingo Molnar <mingo@kernel.org>,
        Yinghai Lu <yhlu.kernel@gmail.com>,
        LKML <linux-kernel@vger.kernel.org>,
        Paolo Bonzini <pbonzini@redhat.com>
Subject: Re: [qemu64,+smep,+smap] WARNING: CPU: 1 PID: 0 at
 arch/x86/kernel/cpu/amd.c:220 init_amd()
Message-ID: <20140307220655.GA580@redhat.com>
Mail-Followup-To: Dave Jones <davej@redhat.com>,
	Borislav Petkov <bp@alien8.de>,
	"H. Peter Anvin" <hpa@linux.intel.com>,
	Fengguang Wu <fengguang.wu@intel.com>,
	Ingo Molnar <mingo@kernel.org>, Yinghai Lu <yhlu.kernel@gmail.com>,
	LKML <linux-kernel@vger.kernel.org>,
	Paolo Bonzini <pbonzini@redhat.com>
References: <20140307015833.GA10048@localhost>
 <53195336.9080606@linux.intel.com>
 <20140307055035.GA5230@localhost>
 <531A164B.8040402@linux.intel.com>
 <20140307191050.GA10961@redhat.com>
 <531A33A2.5030706@linux.intel.com>
 <20140307213856.GF5255@pd.tnic>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20140307213856.GF5255@pd.tnic>
User-Agent: Mutt/1.5.21 (2010-09-15)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Fri, Mar 07, 2014 at 10:38:56PM +0100, Borislav Petkov wrote:

 > * Another option would be if we change the f/m/s of "qemu64" so that
 > the test doesn't fire.
 > 
 > What also makes me wonder is why is this thing even called qemu64?? AMD
 > family 6 was 32-bit only CPUs so 64 is kinda wrong IMO. I mean, the
 > kernel code is in "ifdef CONFIG_X86_32" block so "qemu64" is patently
 > wrong naming.

Additionally, fam:6 model:6 stepping 3 never existed in the real world afaict.
I used to keep x86info's stepping db pretty up to date, and that only has knowledge
of stepping 1 & 2.[*]  Modelling qemu on something from the real world might be
a better idea than inventing new special cases.

 > Oh, and the thing has CPUID_EXT2_LM which is also a WTH moment for me.
 > Paolo, what's going on here?

Yeah, this is a mess, there should be no family < 0xf with LM set.

	Dave

[*] It's possible I somehow missed it, or the AMD rev docs never mentioned it
for some reason, but it seems unlikely.