From: Oleg Nesterov <oleg@redhat.com>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Davidlohr Bueso <davidlohr@hp.com>,
Andrew Morton <akpm@linux-foundation.org>,
Ingo Molnar <mingo@kernel.org>,
Peter Zijlstra <peterz@infradead.org>,
Michel Lespinasse <walken@google.com>,
Mel Gorman <mgorman@suse.de>, Rik van Riel <riel@redhat.com>,
KOSAKI Motohiro <kosaki.motohiro@gmail.com>,
Davidlohr Bueso <davi@redhat.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v4] mm: per-thread vma caching
Date: Sat, 8 Mar 2014 20:57:05 +0100 [thread overview]
Message-ID: <20140308195705.GA588@redhat.com> (raw)
In-Reply-To: <CA+55aFw88xiY+o5FE6VtHNkpUZDK3FPt31oCpNsgn1BH7wAPZw@mail.gmail.com>
looks like I removed lkml somehow, resend...
On 03/08, Linus Torvalds wrote:
>
> On Sat, Mar 8, 2014 at 10:40 AM, Oleg Nesterov <oleg@redhat.com> wrote:
> >
> > It seems this should be moved into copy_mm(), CLONE_VM needs to invalidate
> > ->vmacache too.
>
> No it doesn't. CLONE_VM doesn't change any of the vma lists,
Sure. But another thread or CLONE_VM task can do vmacache_invalidate(),
hit vmacache_seqnum == 0 and call vmacache_flush_all() to solve the
problem with potential overflow.
> so
> there's no reason to invalidate anything.
>
> > dup_task_struct() also copies vmacache_seqnum/vmacache, but the new thread
> > is not yet visible to vmacache_flush_all().
>
> So either the new task struct will share the mm, in which case the
> cache entries are fine
Not if they should be flushed by vmacache_flush_all() above.
Oleg.
next prev parent reply other threads:[~2014-03-08 19:58 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-27 21:48 [PATCH v4] mm: per-thread vma caching Davidlohr Bueso
2014-02-28 4:39 ` Davidlohr Bueso
[not found] ` <20140303160021.3001634fa62781d7b0359158@linux-foundation.org>
2014-03-04 0:18 ` Davidlohr Bueso
[not found] ` <20140303164002.02df915e12d05bb98762407f@linux-foundation.org>
2014-03-04 0:59 ` Davidlohr Bueso
[not found] ` <20140303172348.3f00c9df.akpm@linux-foundation.org>
2014-03-04 2:42 ` Davidlohr Bueso
[not found] ` <20140303191224.96f93142.akpm@linux-foundation.org>
2014-03-04 3:13 ` Davidlohr Bueso
2014-03-04 3:26 ` Linus Torvalds
2014-03-04 5:32 ` Davidlohr Bueso
2014-03-14 3:05 ` Li Zefan
2014-03-14 4:43 ` Andrew Morton
2014-03-06 22:56 ` Andrew Morton
[not found] ` <20140308184040.GA29602@redhat.com>
[not found] ` <CA+55aFw88xiY+o5FE6VtHNkpUZDK3FPt31oCpNsgn1BH7wAPZw@mail.gmail.com>
2014-03-08 19:57 ` Oleg Nesterov [this message]
[not found] ` <20140308194405.GA32403@redhat.com>
2014-03-08 20:02 ` Linus Torvalds
2014-03-09 3:22 ` Davidlohr Bueso
2014-03-09 12:57 ` Oleg Nesterov
2014-03-09 15:57 ` Linus Torvalds
2014-03-09 17:09 ` Oleg Nesterov
2014-03-09 17:16 ` Linus Torvalds
2014-03-10 19:56 ` [PATCH -next] mm,vmacache: also flush cache for VM_CLONE Davidlohr Bueso
2014-03-13 14:59 ` Oleg Nesterov
2014-03-13 15:32 ` Oleg Nesterov
2014-03-13 19:04 ` Davidlohr Bueso
[not found] ` <CA+55aFyNd7L+G3hFauJPxUOengK-_o2G-SFmVooPZ-sE6xBj=g@mail.gmail.com>
2014-03-13 16:36 ` Oleg Nesterov
2014-03-13 18:27 ` async_pf.c && use_mm() (Was: mm,vmacache: also flush cache for VM_CLONE) Oleg Nesterov
[not found] ` <CA+55aFwqTbsYCyPf6_i6RmBkPHpEhJjiRfZm6_1_yPa_kUkYiQ@mail.gmail.com>
2014-03-13 21:44 ` Linus Torvalds
2014-03-14 18:23 ` Oleg Nesterov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140308195705.GA588@redhat.com \
--to=oleg@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=davi@redhat.com \
--cc=davidlohr@hp.com \
--cc=kosaki.motohiro@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mgorman@suse.de \
--cc=mingo@kernel.org \
--cc=peterz@infradead.org \
--cc=riel@redhat.com \
--cc=torvalds@linux-foundation.org \
--cc=walken@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox