Re: [PATCH 00/18] Resend of usbip-utils migration patches and various other fixes

Greg KH
2014-03-09T16:58:06Z

On Sun, Mar 09, 2014 at 05:53:51PM +0200, Valentina Manea wrote:
> I was notified that one of the patches in the series (staging: usbip:
> claim ports used by shared devices) breaks the build.
> I take full responsability for this as I haven't compiled the kernel
> with allyesconfig and I am sorry.

No worries, it happens to all of us :)

> This can be fixed by moving struct dev_state, usb_hub_claim_port() and
> usb_hub_release_port() declarations from include/linux/usb.h to
> usbip/stub.h, and leaving the declarations in usb/core/usb.h
> untouched.
>
> Should the fix come as a separate patch or v2 of the broken one?

No, I can't redo the patch that I've already committed.

As "dev_state" is a very generic term, how about we just rename it to
something more USB specific, like usb_dev_state? That way it would fix
the build issue, and keep it from being a problem in the future in other
drivers.

thanks,

greg k-h