From: Wolfram Sang <wsa@the-dreams.de>
To: Romain Baeriswyl <Romain.Baeriswyl@abilis.com>
Cc: Rob Herring <rob.herring@calxeda.com>,
Pawel Moll <pawel.moll@arm.com>,
Mark Rutland <mark.rutland@arm.com>,
Stephen Warren <swarren@wwwdotorg.org>,
Ian Campbell <ijc+devicetree@hellion.org.uk>,
Rob Landley <rob@landley.net>,
Pierrick Hascoet <pierrick.hascoet@abilis.com>,
Vineet Gupta <vgupta@synopsys.com>,
Christian Ruppert <christian.ruppert@abilis.com>,
Mika Westerberg <mika.westerberg@linux.intel.com>,
Chiau Ee Chew <chiau.ee.chew@intel.com>,
Shinya Kuribayashi <skuribay@pobox.com>,
Jean Delvare <khali@linux-fr.org>,
"Rafael J. Wysocki" <rafael.j.wysocki@intel.com>,
devicetree@vger.kernel.org, linux-doc@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-i2c@vger.kernel.org,
romainba@abilis.com
Subject: Re: [PATCH v2 2/2] i2c designware add support of I2C standard mode
Date: Sun, 9 Mar 2014 09:07:53 +0100 [thread overview]
Message-ID: <20140309080753.GC2575@katana> (raw)
In-Reply-To: <1390236338-21407-1-git-send-email-romainba@abilis.com>
[-- Attachment #1: Type: text/plain, Size: 356 bytes --]
> + /* fast mode by default */
Please add "because of legacy reasons" since the usual default is
100kHz.
> + clk_freq = 400000;
> + /* Only standard mode at 100kHz and fast mode at 400kHz
> + * are supported.
> + */
> + if (clk_freq != 100000 && clk_freq != 400000)
> + return -EINVAL;
You didn't add the error message I requested last time.
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
next prev parent reply other threads:[~2014-03-09 8:08 UTC|newest]
Thread overview: 42+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-08 11:45 [PATCH 1/2] i2c-designware: make *CNT values configurable Mika Westerberg
2013-07-08 11:45 ` [PATCH 2/2] i2c-designware: configure *CNT values from ACPI Mika Westerberg
2013-07-10 13:01 ` Mika Westerberg
2013-07-08 13:42 ` [PATCH 1/2] i2c-designware: make *CNT values configurable Christian Ruppert
2013-07-09 8:44 ` Mika Westerberg
2013-07-09 16:19 ` Christian Ruppert
2013-07-10 10:52 ` Mika Westerberg
2013-07-10 16:56 ` Christian Ruppert
2013-07-11 7:36 ` Mika Westerberg
2013-07-11 10:13 ` Mika Westerberg
2013-07-12 7:56 ` Shinya Kuribayashi
2013-07-12 8:51 ` Mika Westerberg
2013-07-13 5:36 ` Shinya Kuribayashi
2013-07-16 11:16 ` Christian Ruppert
2013-07-17 14:39 ` Shinya Kuribayashi
2013-07-22 13:17 ` Christian Ruppert
2013-07-24 14:31 ` Shinya Kuribayashi
2013-08-05 9:31 ` Christian Ruppert
2013-08-05 10:02 ` Wolfram Sang
2013-08-12 7:48 ` Christian Ruppert
2013-08-12 11:09 ` Wolfram Sang
2013-08-16 2:15 ` Shinya Kuribayashi
2013-08-19 11:36 ` Mika Westerberg
2013-08-19 12:22 ` Shinya Kuribayashi
2013-08-21 14:39 ` Christian Ruppert
2013-08-24 4:58 ` Shinya Kuribayashi
2013-08-28 15:34 ` Christian Ruppert
2013-10-08 15:00 ` [PATCH 1/2] i2c designware make SCL and SDA falling time configurable Romain Baeriswyl
2013-10-09 7:55 ` Mika Westerberg
2013-10-10 0:54 ` Ryan Mallon
2013-10-13 11:36 ` Shinya Kuribayashi
2014-01-16 19:43 ` Wolfram Sang
2014-01-20 16:43 ` [PATCH v2 " Romain Baeriswyl
2014-03-09 8:20 ` Wolfram Sang
2013-10-08 15:00 ` [PATCH 2/2] i2c designware add support of I2C standard mode Romain Baeriswyl
2013-10-09 7:56 ` Mika Westerberg
2013-10-13 11:46 ` Shinya Kuribayashi
2014-01-16 19:33 ` Wolfram Sang
2014-01-20 16:45 ` [PATCH v2 " Romain Baeriswyl
2014-03-09 8:07 ` Wolfram Sang [this message]
2014-03-25 10:18 ` [PATCH V3 " Romain Baeriswyl
2013-08-19 6:39 ` [PATCH 1/2] i2c-designware: make *CNT values configurable Mika Westerberg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140309080753.GC2575@katana \
--to=wsa@the-dreams.de \
--cc=Romain.Baeriswyl@abilis.com \
--cc=chiau.ee.chew@intel.com \
--cc=christian.ruppert@abilis.com \
--cc=devicetree@vger.kernel.org \
--cc=ijc+devicetree@hellion.org.uk \
--cc=khali@linux-fr.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mika.westerberg@linux.intel.com \
--cc=pawel.moll@arm.com \
--cc=pierrick.hascoet@abilis.com \
--cc=rafael.j.wysocki@intel.com \
--cc=rob.herring@calxeda.com \
--cc=rob@landley.net \
--cc=romainba@abilis.com \
--cc=skuribay@pobox.com \
--cc=swarren@wwwdotorg.org \
--cc=vgupta@synopsys.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox