From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753326AbaCJIgB (ORCPT ); Mon, 10 Mar 2014 04:36:01 -0400 Received: from mail-wg0-f52.google.com ([74.125.82.52]:49787 "EHLO mail-wg0-f52.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753295AbaCJIf6 (ORCPT ); Mon, 10 Mar 2014 04:35:58 -0400 Date: Mon, 10 Mar 2014 08:35:52 +0000 From: Lee Jones To: Jenny TC Cc: linux-kernel@vger.kernel.org, Dmitry Eremin-Solenikov , Anton Vorontsov , Anton Vorontsov , Kim Milo , Jingoo Han , Chanwoo Choi , Sachin Kamat , Lars-Peter Clausen , Pali =?iso-8859-1?Q?Roh=E1r?= , Rhyland Klein , Pavel Machek , "Rafael J. Wysocki" , David Woodhouse , Tony Lindgren , Russell King , Sebastian Reichel , aaro.koskinen@iki.fi, Pallala Ramakrishna , freemangordon@abv.bg, linux-omap@vger.kernel.org Subject: Re: [PATCHv8 0/4] power_supply: Introduce power supply charging driver Message-ID: <20140310083552.GB14976@lee--X1> References: <1394170174-21959-1-git-send-email-jenny.tc@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1394170174-21959-1-git-send-email-jenny.tc@intel.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Jenny, Would you mind _not_ CC'ing me on all of your emails please? I have enough _relevant_ email to deal with already without seeing this churn constantly. Thanks in advance. > v1: introduced feature as a framework within power supply class driver with > separate files for battid framework and charging framework > v2: fixed review comments, moved macros and inline functions to power_supply.h > v3: moved the feature as a separate driver, combined battid framework and > charging framework inside the power supply charging driver. Moved > charger specific properties to power_supply_charger.h and plugged the > driver with power supply subsystem using power_supply_notifier > introduced in my previous patch. Also a sample charger chip driver > (bq24261) patch added to give more idea on the psy charging driver > usage > v4: Fixed review comments, no major design changes. > v5: Fixed makefile inconsistencies, removed unused pdata callbacks > v6: Fixed nested loops, commenting style > v7: added kerneldocs for structs and minor fixes > v8: used msecs_to_jiffies instead of HZ directly, modified Kconfig help text > for POWER_SUPPLY_CHARGING_ALGO_PSE > > The Power Supply charging driver connects multiple subsystems > to do charging in a generic way. The subsystems involves power_supply, > thermal and battery communication subsystems (1wire).With this the charging is > handled in a generic way. > > The driver makes use of different new features - Battery Identification > interfaces, pluggable charging algorithms, charger cable arbitrations etc. > The patch also introduces generic interface for charger cable notifications. > Charger cable events and capabilities can be notified using the generic > power_supply_notifier chain. > > Overall this driver removes the charging logic out of the charger chip driver > and the charger chip driver can just listen to the request from the power > supply charging driver to set the charger properties. This can be implemented > by exposing get_property and set property callbacks. > > Jenny TC (4): > power_supply: Add inlmt,iterm, min/max temp props > power_supply: Introduce generic psy charging driver > power_supply: Introduce PSE compliant algorithm > power_supply: bq24261 charger driver > > Documentation/power/power_supply_charger.txt | 353 +++++++ > Documentation/power/power_supply_class.txt | 6 + > drivers/power/Kconfig | 31 + > drivers/power/Makefile | 3 + > drivers/power/bq24261-charger.c | 1350 ++++++++++++++++++++++++++ > drivers/power/charging_algo_pse.c | 204 ++++ > drivers/power/power_supply_charger.c | 1186 ++++++++++++++++++++++ > drivers/power/power_supply_charger.h | 218 +++++ > drivers/power/power_supply_core.c | 3 + > drivers/power/power_supply_sysfs.c | 4 + > include/linux/power/bq24261-charger.h | 25 + > include/linux/power/power_supply_charger.h | 341 +++++++ > include/linux/power_supply.h | 164 ++++ > 13 files changed, 3888 insertions(+) > create mode 100644 Documentation/power/power_supply_charger.txt > create mode 100644 drivers/power/bq24261-charger.c > create mode 100644 drivers/power/charging_algo_pse.c > create mode 100644 drivers/power/power_supply_charger.c > create mode 100644 drivers/power/power_supply_charger.h > create mode 100644 include/linux/power/bq24261-charger.h > create mode 100644 include/linux/power/power_supply_charger.h > -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog