From: Lee Jones <lee.jones@linaro.org>
To: Sachin Kamat <sachin.kamat@linaro.org>
Cc: Krzysztof Kozlowski <k.kozlowski@samsung.com>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v3 Resend 2/3] regulator: Add support for S2MPA01 regulator
Date: Mon, 10 Mar 2014 09:35:51 +0000 [thread overview]
Message-ID: <20140310093551.GE14976@lee--X1> (raw)
In-Reply-To: <CAK9yfHyv+PhLCfy131KCS4GWaAEgQ9qmS5X27bTYHWYUspkYjA@mail.gmail.com>
> >> Add support for S2MPA01 voltage and current regulator.
>
> >> +
> >> +struct s2mpa01_info {
> >> + struct regulator_dev *rdev[S2MPA01_REGULATOR_MAX];
> >
> > Hi,
> >
> > It seems that s2mpa01_info->rdev is not used anywhere, except as return
> > value of devm_regulator_register. I think you can remove it completely.
>
> Yes. I will send a follow up patch for this.
Let's not break things and fix them up later. Fix it in this patch.
> > Beside that, can this driver be merged into existing s2mps11 regulator
> > driver?
>
> Haven't analyzed this yet. Will look into the possibility of consolidation
> later.
As above. If consolidation is possible it should be take care of in
the first instance.
--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
next prev parent reply other threads:[~2014-03-10 9:35 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-06 10:00 [PATCH v3 Resend 1/3] mfd: Add support for S2MPA01 device Sachin Kamat
2014-03-06 10:00 ` [PATCH v3 Resend 2/3] regulator: Add support for S2MPA01 regulator Sachin Kamat
2014-03-06 10:40 ` Krzysztof Kozlowski
2014-03-06 11:22 ` Sachin Kamat
2014-03-10 9:35 ` Lee Jones [this message]
2014-03-10 9:56 ` Sachin Kamat
2014-03-10 10:38 ` Lee Jones
2014-03-10 10:39 ` Lee Jones
2014-03-10 10:42 ` Sachin Kamat
2014-03-06 10:00 ` [PATCH v3 Resend 3/3] Documentation: mfd: Add binding document for S2MPA01 Sachin Kamat
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140310093551.GE14976@lee--X1 \
--to=lee.jones@linaro.org \
--cc=k.kozlowski@samsung.com \
--cc=linux-kernel@vger.kernel.org \
--cc=sachin.kamat@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox