From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1753264AbaCJLu3 (ORCPT <rfc822;w@1wt.eu>);
	Mon, 10 Mar 2014 07:50:29 -0400
Received: from mail-wg0-f43.google.com ([74.125.82.43]:63043 "EHLO
	mail-wg0-f43.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1752651AbaCJLu1 (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Mon, 10 Mar 2014 07:50:27 -0400
Date: Mon, 10 Mar 2014 11:50:21 +0000
From: Lee Jones <lee.jones@linaro.org>
To: Gabriel FERNANDEZ <gabriel.fernandez@st.com>
Cc: Dmitry Torokhov <dmitry.torokhov@gmail.com>,
        Rob Herring <robh+dt@kernel.org>, Pawel Moll <pawel.moll@arm.com>,
        Mark Rutland <mark.rutland@arm.com>,
        Ian Campbell <ijc+devicetree@hellion.org.uk>,
        Kumar Gala <galak@codeaurora.org>, Rob Landley <rob@landley.net>,
        Russell King <linux@arm.linux.org.uk>,
        Grant Likely <grant.likely@linaro.org>, devicetree@vger.kernel.org,
        linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org,
        linux-arm-kernel@lists.infradead.org, linux-input@vger.kernel.org,
        kernel@stlinux.com, Giuseppe CONDORELLI <giuseppe.condorelli@st.com>
Subject: Re: [PATCH 2/5] ARM: STi: DT: add keyscan for stih415
Message-ID: <20140310115021.GP14976@lee--X1>
References: <1393990772-9567-1-git-send-email-gabriel.fernandez@st.com>
 <1393990772-9567-3-git-send-email-gabriel.fernandez@st.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <1393990772-9567-3-git-send-email-gabriel.fernandez@st.com>
User-Agent: Mutt/1.5.21 (2010-09-15)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

> From: Giuseppe CONDORELLI <giuseppe.condorelli@st.com>
> 
> Add keyscan support for stih415.
> It is put disabled by default because it is not enabled on all boards
> Also there are PIOs conflict with already claimed lines.
> 
> Signed-off-by: Giuseppe Condorelli <giuseppe.condorelli@st.com>
> Signed-off-by: Gabriel Fernandez <gabriel.fernandez@st.com>
> ---
>  arch/arm/boot/dts/stih415-pinctrl.dtsi | 16 ++++++++++++++++
>  arch/arm/boot/dts/stih415.dtsi         | 10 ++++++++++
>  2 files changed, 26 insertions(+)

<snip>

> +		keyscan: keyscan@fe4b0000 {
> +			compatible = "st,keypad";
> +			status = "disabled";
> +			reg = <0xfe4b0000 0x2000>;
> +			interrupts = <GIC_SPI 212 IRQ_TYPE_NONE>;
> +			clocks	= <&CLK_SYSIN>;
> +			pinctrl-names	= "default";

Small nit here, but otherwise:
  Acked-by: Lee Jones <lee.jones@linaro.org>

> +			pinctrl-0 = <&pinctrl_keyscan>;
> +		};
>  	};
>  };

-- 
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog