From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754026AbaCJOCr (ORCPT ); Mon, 10 Mar 2014 10:02:47 -0400 Received: from mail-wg0-f48.google.com ([74.125.82.48]:36539 "EHLO mail-wg0-f48.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753388AbaCJOCp (ORCPT ); Mon, 10 Mar 2014 10:02:45 -0400 Date: Mon, 10 Mar 2014 14:02:38 +0000 From: Lee Jones To: "Opensource [Steve Twiss]" Cc: Mark Brown , Philipp Zabel , Samuel Ortiz , David Dajun Chen , LKML Subject: Re: [PATCH V1 1/2] mfd: da9063: Upgrade of register definitions to support production silicon Message-ID: <20140310140238.GA15558@lee--X1> References: <1e3f5e127c375a45b9a8e929fa99fa5c917b1dea.1394124002.git.stwiss.opensource@diasemi.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1e3f5e127c375a45b9a8e929fa99fa5c917b1dea.1394124002.git.stwiss.opensource@diasemi.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > From: Opensource [Steve Twiss] > > This patch updates the register definitions for DA9063 to support the > production silicon variant code ID (0x5). These changes are not backwards > compatible with the previous register definitions and can only be used > with the production variant of DA9063. > > Signed-off-by: Opensource [Steve Twiss] > --- > Checks performed with next-20140306/scripts/checkpatch.pl > registers.h total: 0 errors, 0 warnings, 1032 lines checked > > A brief summary of the changes include: > > - Introduction of a new DA9063_REG_ALARM_S register (now appearing at > addr=0x46) allowing alarm second resolutions and which causes a shift > in the register map for the RTC registers; > - Two new configuration registers DA9063_REG_CONFIG_M/N at 0x112 & 0x113; > - Modified register ranges for MON_REG_[1-6] which now appears at the > addr=0x114 onwards; > - New register addresses for the general purpose registers GP_ID_[0-19] > (now appearing at 0x121 onwards); > - Renaming of some definitions to match our hardware design conventions; > - There are also some bit-pattern additions that define some functionality > alterations of the registers. One notable addition is: > DA9063_BUCK_SLOWSTART can also be found in the CONTROL_B register and > enables a BUCK slow start (reduced inrush current; increased startup > time); > > include/linux/mfd/da9063/registers.h | 120 ++++++++++++++++++---------------- > 1 file changed, 62 insertions(+), 58 deletions(-) Well, as this doesn't seem to cause any issues when building and I'm going to guess that the other patch in the set won't be a problem (as you didn't send it to me, so I'm gussing it's insignificant), I'll apply the patch. Applied, thanks. -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog