public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Wolfram Sang <wsa@the-dreams.de>
To: "Chew, Chiau Ee" <chiau.ee.chew@intel.com>
Cc: Mika Westerberg <mika.westerberg@linux.intel.com>,
	"linux-i2c@vger.kernel.org" <linux-i2c@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 1/2] i2c: designware-pci: add 10-bit addressing mode functionality for BYT I2C
Date: Mon, 10 Mar 2014 16:16:48 +0100	[thread overview]
Message-ID: <20140310151648.GB11592@katana> (raw)
In-Reply-To: <604BF5F4C5D71041942BC7E84ED659EA0155D56E@PGSMSX103.gar.corp.intel.com>

[-- Attachment #1: Type: text/plain, Size: 472 bytes --]

> > > +#define DW_DEFAULT_FUNCTIONALITY (I2C_FUNC_I2C |
> > 	\
> > > +					I2C_FUNC_SMBUS_BYTE |
> > 	\
> > > +					I2C_FUNC_SMBUS_BYTE_DATA |
> > 	\
> > > +					I2C_FUNC_SMBUS_WORD_DATA |
> > 	\
> > > +					I2C_FUNC_SMBUS_I2C_BLOCK)
> > 
> > Can't we have I2C_FUNC_SMBUS_EMUL here? (Need checking with
> > I2C_SMBUS_QUICK)
> 
> Per my understanding, this I2C host is not able to support I2C_SMBUS_QUICK.

Ok. Thanks for checking, will apply this patch.


[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]

  reply	other threads:[~2014-03-10 15:16 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-03-07 14:12 [PATCH 0/2] i2c: designware-pci: extra features for PCI mode LPSS I2C Chew Chiau Ee
2014-03-07 14:12 ` [PATCH 1/2] i2c: designware-pci: add 10-bit addressing mode functionality for BYT I2C Chew Chiau Ee
2014-03-09  8:53   ` Wolfram Sang
2014-03-10 10:12     ` Chew, Chiau Ee
2014-03-10 15:16       ` Wolfram Sang [this message]
2014-03-07 14:12 ` [PATCH 2/2] i2c: designware-pci: set ideal HCNT, LCNT and SDA hold time value Chew Chiau Ee
2014-03-09  9:03   ` Wolfram Sang
2014-03-10 11:34     ` Chew, Chiau Ee
2014-03-10 15:15       ` Wolfram Sang
2014-03-10 15:21   ` Wolfram Sang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140310151648.GB11592@katana \
    --to=wsa@the-dreams.de \
    --cc=chiau.ee.chew@intel.com \
    --cc=linux-i2c@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mika.westerberg@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox