From: Wolfram Sang <wsa@the-dreams.de>
To: Mike Looijmans <mike.looijmans@topic.nl>
Cc: linux-i2c@vger.kernel.org, linux-kernel@vger.kernel.org,
nsekhar@ti.com, khilman@deeprootsystems.com,
davinci-linux-open-source@linux.davincidsp.com
Subject: Re: [PATCH] i2c-davinci: Handle signals gracefully
Date: Mon, 10 Mar 2014 16:24:06 +0100 [thread overview]
Message-ID: <20140310152406.GD11592@katana> (raw)
In-Reply-To: <20140310105952.GA7227@katana>
[-- Attachment #1: Type: text/plain, Size: 715 bytes --]
> > >Even more, you should complete the whole transfer. There are devices
> > >where things can really go wrong if you send a half-complete command and
> > >then start with the next one. So, not checking signals at all is the way
> > >to go for I2C drivers. There is some cruft left, so I am happy about
> > >patches fixing that, with testing on real HW. Like yours here.
> >
> > I agree.
> >
> > I know the Zynq (using a cadence controller) also lets signals
> > interrupt I2C transfers, so I'll propose a patch to Xilinx and CC to
> > you and linux-i2c to completely remove signal handling from that
> > driver as well.
>
> Cool, thanks!
Are you going to update the davinci patch as well?
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
next prev parent reply other threads:[~2014-03-10 15:24 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-09 11:11 [PATCH] i2c-davinci: Handle signals gracefully Mike Looijmans
2014-03-09 20:21 ` Wolfram Sang
2014-03-10 10:24 ` Mike Looijmans
2014-03-10 10:59 ` Wolfram Sang
2014-03-10 15:24 ` Wolfram Sang [this message]
2014-03-14 6:43 ` Mike Looijmans
2014-03-14 6:42 ` Mike Looijmans
2014-03-24 16:14 ` Wolfram Sang
2014-05-21 8:17 ` Wolfram Sang
2014-05-24 11:53 ` Mike Looijmans
2014-06-01 20:11 ` Wolfram Sang
2014-11-08 21:51 ` Wolfram Sang
2014-11-10 14:49 ` Mike Looijmans
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140310152406.GD11592@katana \
--to=wsa@the-dreams.de \
--cc=davinci-linux-open-source@linux.davincidsp.com \
--cc=khilman@deeprootsystems.com \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mike.looijmans@topic.nl \
--cc=nsekhar@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox