Re: [PATCH] i2c-davinci: Handle signals gracefully

Wolfram Sang
2014-03-10T15:24:10Z

[-- Attachment #1: Type: text/plain, Size: 715 bytes --]

> > >Even more, you should complete the whole transfer. There are devices
> > >where things can really go wrong if you send a half-complete command and
> > >then start with the next one. So, not checking signals at all is the way
> > >to go for I2C drivers. There is some cruft left, so I am happy about
> > >patches fixing that, with testing on real HW. Like yours here.
> >
> > I agree.
> >
> > I know the Zynq (using a cadence controller) also lets signals
> > interrupt I2C transfers, so I'll propose a patch to Xilinx and CC to
> > you and linux-i2c to completely remove signal handling from that
> > driver as well.
>
> Cool, thanks!

Are you going to update the davinci patch as well?

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]