The Linux Kernel Mailing List
 help / color / mirror / Atom feed
From: Greg KH <gregkh@linuxfoundation.org>
To: Masood Mehmood <ody.guru@gmail.com>
Cc: devel@driverdev.osuosl.org, lidza.louina@gmail.com,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] staging: dgap: Fixed sparse error: same symbol redeclared with different type
Date: Mon, 10 Mar 2014 11:37:12 -0700	[thread overview]
Message-ID: <20140310183712.GA27534@kroah.com> (raw)
In-Reply-To: <1394349522-20458-1-git-send-email-ody.guru@gmail.com>

On Sat, Mar 08, 2014 at 11:18:42PM -0800, Masood Mehmood wrote:
> sparse reported dgap_do_fep_load is redeclared with different type. while
> fixing, I noticed __user attribute is used incorrectly in declaration.
> There is no need to define __user for firware->data.
> 
> Replaced the __user with 'const uchar *' from function dgap_do_fep_load and
> did the same for function dgap_do_bios_load.
> 
> Signed-off-by: Masood Mehmood <ody.guru@gmail.com>
> ---
>  drivers/staging/dgap/dgap.c | 13 ++++++-------
>  1 file changed, 6 insertions(+), 7 deletions(-)

I don't see a patch 1/2 here, did you forget to send it to me?

thanks,

greg k-h

  reply	other threads:[~2014-03-10 18:55 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-03-09  7:18 [PATCH 2/2] staging: dgap: Fixed sparse error: same symbol redeclared with different type Masood Mehmood
2014-03-10 18:37 ` Greg KH [this message]
2014-03-09  8:33   ` Masood Mehmood
2014-03-10 19:34     ` Greg KH
2014-03-09  8:57       ` Masood Mehmood

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140310183712.GA27534@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=devel@driverdev.osuosl.org \
    --cc=lidza.louina@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=ody.guru@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox