From: Mark Brown <broonie@kernel.org>
To: Josh Cartwright <joshc@codeaurora.org>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Alessandro Zummo <a.zummo@towertech.it>,
linux-arm-msm@vger.kernel.org, rtc-linux@googlegroups.com,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 2/6] rtc: pm8xxx: use regmap API for register accesses
Date: Mon, 10 Mar 2014 23:32:36 +0000 [thread overview]
Message-ID: <20140310233236.GD28112@sirena.org.uk> (raw)
In-Reply-To: <20140310213524.GL18529@joshc.qualcomm.com>
[-- Attachment #1: Type: text/plain, Size: 832 bytes --]
On Mon, Mar 10, 2014 at 04:35:24PM -0500, Josh Cartwright wrote:
> On Mon, Mar 10, 2014 at 01:47:41PM -0700, Andrew Morton wrote:
> > Do we need a
> > depends on REGMAP
> > in Kconfig?
> Good question. This driver already gets the REGMAP dependency through
> it's parent (MFD_PM8XXX), which does 'select REGMAP'.
> I recall there being some history as to why individual drivers shouldn't
> explicitly depend on REGMAP, as it's the parent drivers/subsystem
> responsibility to select it when needed, however I can't recall details.
> Perhaps it's due to REGMAP not being a user-selectable option.
Yeah, it should be a select of regmap because it's more of a helper
library than a user visible feature and it's usually only on the MFD
because you can't enable the function device without the core anyway.
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
next prev parent reply other threads:[~2014-03-10 23:32 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-10 18:44 [PATCH v2 0/6] rtc: make the pm8xxx RTC driver usable Josh Cartwright
2014-03-10 18:44 ` [PATCH v2 1/6] rtc: pm8xxx: fixup checkpatch/style issues Josh Cartwright
2014-03-10 18:44 ` [PATCH v2 2/6] rtc: pm8xxx: use regmap API for register accesses Josh Cartwright
2014-03-10 20:47 ` Andrew Morton
2014-03-10 21:35 ` Josh Cartwright
2014-03-10 21:43 ` Andrew Morton
2014-03-10 23:32 ` Mark Brown [this message]
2014-03-10 18:44 ` [PATCH v2 3/6] rtc: pm8xxx: use devm_request_any_context_irq Josh Cartwright
2014-03-10 18:44 ` [PATCH v2 4/6] rtc: pm8xxx: add support for devicetree Josh Cartwright
2014-03-10 20:47 ` Andrew Morton
2014-03-10 21:56 ` Josh Cartwright
2014-03-10 18:44 ` [PATCH v2 5/6] rtc: pm8xxx: move device_init_wakeup() before rtc_register Josh Cartwright
2014-03-10 18:44 ` [PATCH v2 6/6] documentation: bindings: document PMIC8921/8058 RTC Josh Cartwright
2014-03-10 21:22 ` Rob Herring
2014-03-10 22:11 ` Josh Cartwright
2014-03-10 22:18 ` Andrew Morton
2014-03-12 17:17 ` [PATCH v3 6/6] mfd: devicetree: bindings: add pm8xxx RTC description Josh Cartwright
2014-03-21 8:12 ` Lee Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140310233236.GD28112@sirena.org.uk \
--to=broonie@kernel.org \
--cc=a.zummo@towertech.it \
--cc=akpm@linux-foundation.org \
--cc=joshc@codeaurora.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rtc-linux@googlegroups.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox