From: Lee Jones <lee.jones@linaro.org>
To: Maxime Coquelin <maxime.coquelin@st.com>
Cc: linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, srinivas.kandagatla@st.com
Subject: Re: [PATCH 2/3] ARM: STi: stih416-b2020: Explicitly include STiH416 Pinctrl bindings
Date: Tue, 11 Mar 2014 11:20:27 +0000 [thread overview]
Message-ID: <20140311112027.GD21216@lee--X1> (raw)
In-Reply-To: <531EEADF.5060001@st.com>
> >At the moment we're relying on inheriting them from DTSI files which
> >we're including Ideally we should be specifying these for ourselves.
> >
> >Signed-off-by: Lee Jones <lee.jones@linaro.org>
> >---
> > arch/arm/boot/dts/stih416-b2020-revE.dts | 1 +
> > 1 file changed, 1 insertion(+)
> >
> >diff --git a/arch/arm/boot/dts/stih416-b2020-revE.dts b/arch/arm/boot/dts/stih416-b2020-revE.dts
> >index bcb9d00..4168b019 100644
> >--- a/arch/arm/boot/dts/stih416-b2020-revE.dts
> >+++ b/arch/arm/boot/dts/stih416-b2020-revE.dts
> >@@ -8,6 +8,7 @@
> > */
> > /dts-v1/;
> > #include "stih416.dtsi"
> >+#include "stih416-pinctrl.dtsi"
> Isn't this file already included in stih416.dtsi?
It is, but it's being inherited. I'm unsure if the DT rules are
different, but in *.c files #includes should be added explicitly in
the file they are used.
--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
next prev parent reply other threads:[~2014-03-11 11:20 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-11 10:22 [PATCH 1/3] ARM: DT: STi: Add support to B2020 revision E board Lee Jones
2014-03-11 10:22 ` [PATCH 2/3] ARM: STi: stih416-b2020: Explicitly include STiH416 Pinctrl bindings Lee Jones
2014-03-11 10:52 ` Maxime Coquelin
2014-03-11 11:17 ` Lee Jones
2014-03-11 11:20 ` Lee Jones [this message]
2014-03-11 10:22 ` [PATCH 3/3] ARM: STi: stih41x: Provide a proper header for this DTSI file Lee Jones
2014-03-11 10:49 ` [PATCH 1/3] ARM: DT: STi: Add support to B2020 revision E board Maxime Coquelin
2014-03-11 11:23 ` Lee Jones
2014-03-11 12:15 ` Maxime Coquelin
2014-03-11 13:23 ` Lee Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140311112027.GD21216@lee--X1 \
--to=lee.jones@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=maxime.coquelin@st.com \
--cc=srinivas.kandagatla@st.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox