public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Mike Snitzer <snitzer@redhat.com>
To: Arnd Bergmann <arnd@arndb.de>
Cc: dm-devel@redhat.com, Alasdair Kergon <agk@redhat.com>,
	Joe Thornber <ejt@redhat.com>,
	linux-kernel@vger.kernel.org
Subject: Re: dm: era: use do_div for 64-bit division
Date: Tue, 11 Mar 2014 08:59:54 -0400	[thread overview]
Message-ID: <20140311125954.GA9752@redhat.com> (raw)
In-Reply-To: <3014967.i7OXqBNQ5E@wuerfel>

On Tue, Mar 11 2014 at  4:31am -0400,
Arnd Bergmann <arnd@arndb.de> wrote:

> Commit 983043be0c1de "dm era: support non power-of-2 blocksize"
> introduced the use of sector_div to divide a variable of type
> dm_block_t by an integer. This fails on 32-bit machines when
> CONFIG_LBDAF is not set, because that assumes that the first
> argument is a 32-bit number.
> 
> To allow building this driver in all configurations, we either
> have to cast the dm_block_t to sector_t or use do_div(), which
> always takes a 64-bit argument. This patch uses the second
> approach in order to cope with theoretical configurations where
> dm_block_t contains a number that does not fit into sector_t.

Thanks for taking the time to look into this.

But the first approach was used on Friday (and is adequate considering
we're starting with the bio's bi_sector).  The new commit id is
1c5a63b138638d08f4dc65ed48d3d5d3bad1b08b.

The moral of the story is: don't make a mistake on Thursday because that
last linux-next of the week will plague you for the next 5 days.  I was
hoping for relief with Monday's linux-next build but alas... ;)

      reply	other threads:[~2014-03-11 13:00 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-03-11  8:31 [PATCH] dm: era: use do_div for 64-bit division Arnd Bergmann
2014-03-11 12:59 ` Mike Snitzer [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140311125954.GA9752@redhat.com \
    --to=snitzer@redhat.com \
    --cc=agk@redhat.com \
    --cc=arnd@arndb.de \
    --cc=dm-devel@redhat.com \
    --cc=ejt@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox