public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Jiri Olsa <jolsa@redhat.com>
To: Andi Kleen <andi@firstfloor.org>
Cc: acme@infradead.org, mingo@kernel.org,
	linux-kernel@vger.kernel.org, peterz@infradead.org,
	eranian@google.com, namhyung@kernel.org,
	Andi Kleen <ak@linux.intel.com>
Subject: Re: [PATCH 2/8] perf, tools: Add support for reading JSON event files
Date: Tue, 11 Mar 2014 14:37:32 +0100	[thread overview]
Message-ID: <20140311133732.GA22678@krava.redhat.com> (raw)
In-Reply-To: <1394048978-15909-3-git-send-email-andi@firstfloor.org>

On Wed, Mar 05, 2014 at 11:49:32AM -0800, Andi Kleen wrote:
> From: Andi Kleen <ak@linux.intel.com>
> 
> Add a parser for Intel style JSON event files. This allows
> to use an Intel event list directly with perf. The Intel
> event lists can be quite large and are too big to store
> in unswappable kernel memory.
> 
> The parser code knows how to convert the JSON fields
> to perf fields. The conversion code is straight forward.
> It knows (very little) Intel specific information, and can be easily
> extended to handle fields for other CPUs.
> 
> The parser code is partially shared with an independent parsing
> library, which is 2-clause BSD licenced. To avoid any conflicts I marked
> those files as BSD licenced too. As part of perf they become GPLv2.
> 
> The events are handled using the existing alias machinery.
> 
> We output the BriefDescription in perf list.
> 
> Right now the json file can be specified as an argument
> to perf stat/record/list. Followon patches will automate this.
> 
> Signed-off-by: Andi Kleen <ak@linux.intel.com>
> ---
>  tools/perf/Documentation/perf-list.txt   |   6 +
>  tools/perf/Documentation/perf-record.txt |   3 +
>  tools/perf/Documentation/perf-stat.txt   |   3 +
>  tools/perf/Makefile.perf                 |   2 +
>  tools/perf/builtin-list.c                |   2 +
>  tools/perf/builtin-record.c              |   3 +
>  tools/perf/builtin-stat.c                |   2 +
>  tools/perf/util/jevents.c                | 248 +++++++++++++++++++++++++++++++
>  tools/perf/util/jevents.h                |   3 +
>  tools/perf/util/pmu.c                    | 141 ++++++++++++++----
>  tools/perf/util/pmu.h                    |   2 +

please put the alias code factoring (perf_pmu__new_alias)
and print_pmu_events changes to separate commits

jirka

  reply	other threads:[~2014-03-11 14:05 UTC|newest]

Thread overview: 27+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-03-05 19:49 perf: Add support for full Intel event lists Andi Kleen
2014-03-05 19:49 ` [PATCH 1/8] perf, tools: Add jsmn `jasmine' JSON parser Andi Kleen
2014-03-11 10:23   ` Jiri Olsa
2014-03-11 13:37   ` Jiri Olsa
2014-03-11 13:38   ` Jiri Olsa
2014-03-13 20:06     ` Andi Kleen
2014-03-11 13:38   ` Jiri Olsa
2014-03-13 20:07     ` Andi Kleen
2014-03-11 13:38   ` Jiri Olsa
2014-03-05 19:49 ` [PATCH 2/8] perf, tools: Add support for reading JSON event files Andi Kleen
2014-03-11 13:37   ` Jiri Olsa [this message]
2014-03-05 19:49 ` [PATCH 3/8] perf, tools: Automatically look for event file name for cpu Andi Kleen
2014-03-11 13:37   ` Jiri Olsa
2014-03-05 19:49 ` [PATCH 4/8] perf, tools: Add perf download to download event files Andi Kleen
2014-03-05 19:49 ` [PATCH 5/8] perf, tools: Allow events with dot Andi Kleen
2014-03-05 19:49 ` [PATCH 6/8] perf, tools: Query terminal width and use in perf list Andi Kleen
2014-03-11 13:41   ` Jiri Olsa
2014-03-05 19:49 ` [PATCH 7/8] perf, tools, record: Always allow to overide default period Andi Kleen
2014-03-11 14:26   ` Jiri Olsa
2014-03-05 19:49 ` [PATCH 8/8] perf, tools, test: Add test case for alias and JSON parsing Andi Kleen
2014-03-11 14:31   ` Jiri Olsa
2014-03-14 21:12     ` Andi Kleen
2014-03-06  9:37 ` perf: Add support for full Intel event lists Jiri Olsa
2014-03-10 19:39 ` Ben Hutchings
2014-03-10 22:14   ` Andi Kleen
2014-03-10 23:13     ` Ben Hutchings
2014-03-10 23:31       ` Andi Kleen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140311133732.GA22678@krava.redhat.com \
    --to=jolsa@redhat.com \
    --cc=acme@infradead.org \
    --cc=ak@linux.intel.com \
    --cc=andi@firstfloor.org \
    --cc=eranian@google.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@kernel.org \
    --cc=namhyung@kernel.org \
    --cc=peterz@infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox