public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Julian Wollrath <jwollrath@web.de>
To: Thomas Gleixner <tglx@linutronix.de>
Cc: x86@kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [RESEND] Fast TSC calibration fails with v3.14-rc1 and later
Date: Tue, 11 Mar 2014 14:29:10 +0100	[thread overview]
Message-ID: <20140311142910.27594027@ilfaris> (raw)
In-Reply-To: <alpine.DEB.2.02.1403101123470.18573@ionos.tec.linutronix.de>

Am Mon, 10 Mar 2014 11:39:44 +0100 (CET)
schrieb Thomas Gleixner <tglx@linutronix.de>:
> And that definitely does not affect the quick calibration. No idea,
> except bisecting.
Ok, via bisecting I found commit
73f7d1ca32638028e3271f54616773727e2f9f26 (see below) to be the one that
introduced this regression.


Cheers,
Julian Wollrath

>From 73f7d1ca32638028e3271f54616773727e2f9f26 Mon Sep 17 00:00:00 2001
From: "Lee, Chun-Yi" <joeyli.kernel@gmail.com>
Date: Wed, 15 Jan 2014 15:25:48 +0800
Subject: [PATCH] ACPI / init: Run acpi_early_init() before timekeeping_init()

This is a variant patch from Rafael J. Wysocki's
ACPI / init: Run acpi_early_init() before efi_enter_virtual_mode()

According to Matt Fleming, if acpi_early_init() was executed before
efi_enter_virtual_mode(), the EFI initialization could benefit from
it, so Rafael's patch makes that happen.

And, we want accessing ACPI TAD device to set system clock, so move
acpi_early_init() before timekeeping_init(). This final position is
also before efi_enter_virtual_mode().

Tested-by: Toshi Kani <toshi.kani@hp.com>
Signed-off-by: Lee, Chun-Yi <jlee@suse.com>
Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
---
 init/main.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/init/main.c b/init/main.c
index febc511e078a..b6d93c840154 100644
--- a/init/main.c
+++ b/init/main.c
@@ -565,6 +565,7 @@ asmlinkage void __init start_kernel(void)
 	init_timers();
 	hrtimers_init();
 	softirq_init();
+	acpi_early_init();
 	timekeeping_init();
 	time_init();
 	sched_clock_postinit();
@@ -641,7 +642,6 @@ asmlinkage void __init start_kernel(void)
 
 	check_bugs();
 
-	acpi_early_init(); /* before LAPIC and SMP init */
 	sfi_init_late();
 
 	if (efi_enabled(EFI_RUNTIME_SERVICES)) {
-- 
1.9.0


  reply	other threads:[~2014-03-11 13:29 UTC|newest]

Thread overview: 41+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-03-10 10:04 [RESEND] Fast TSC calibration fails with v3.14-rc1 and later Julian Wollrath
2014-03-10 10:27 ` Paul Bolle
2014-03-10 14:06   ` Thomas Gleixner
2014-03-10 15:28     ` Paul Bolle
2014-03-10 17:04       ` Thomas Gleixner
2014-03-10 18:32         ` Paul Bolle
2014-03-10 18:57           ` Thomas Gleixner
2014-03-10 19:19             ` Paul Bolle
2014-03-10 20:50               ` Thomas Gleixner
2014-03-10 23:06                 ` Paul Bolle
2014-03-11 16:02                   ` Thomas Gleixner
2014-03-11 13:27       ` Julian Wollrath
2014-03-10 10:39 ` Thomas Gleixner
2014-03-11 13:29   ` Julian Wollrath [this message]
2014-03-11 13:56     ` Thomas Gleixner
2014-03-11 17:15       ` Julian Wollrath
2014-03-12  4:00         ` joeyli
2014-03-12 10:20           ` Julian Wollrath
2014-03-12 13:52             ` joeyli
2014-03-12 11:20           ` Rafael J. Wysocki
2014-03-12 13:30             ` Rafael J. Wysocki
2014-03-12 13:55               ` Julian Wollrath
2014-03-12 15:41               ` joeyli
2014-03-12 16:20                 ` Thomas Gleixner
2014-03-12 16:23                   ` Thomas Gleixner
2014-03-12 16:39                     ` Thomas Gleixner
2014-03-12 23:27                       ` Rafael J. Wysocki
2014-03-12 23:49                         ` Thomas Gleixner
2014-03-13  0:13                           ` Rafael J. Wysocki
2014-03-13  2:56                           ` joeyli
2014-03-13  0:54                         ` Thomas Gleixner
2014-03-13  1:01                           ` Thomas Gleixner
2014-03-13  2:38                           ` joeyli
2014-03-13  3:11                             ` H. Peter Anvin
2014-03-13  3:55                               ` joeyli
2014-03-13  3:59                                 ` H. Peter Anvin
2014-03-13  4:12                                   ` joeyli
2014-03-13  8:12                                     ` Thomas Gleixner
2014-03-13  8:59                                       ` joeyli
2014-03-13  3:41                           ` H. Peter Anvin
2014-03-12 14:00             ` joeyli

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140311142910.27594027@ilfaris \
    --to=jwollrath@web.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=tglx@linutronix.de \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox