linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* Re: [powerpc:next 45/53] warning: (PPC_C2K && ..) selects NOT_COHERENT_CACHE which has unmet direct dependencies (4xx || ..)
       [not found] ` <531DD0F4.6020000@windriver.com>
@ 2014-03-11  4:54   ` Fengguang Wu
  2014-03-11 14:32     ` Paul Gortmaker
  0 siblings, 1 reply; 3+ messages in thread
From: Fengguang Wu @ 2014-03-11  4:54 UTC (permalink / raw)
  To: Paul Gortmaker; +Cc: Benjamin Herrenschmidt, kbuild-all, LKML

On Mon, Mar 10, 2014 at 10:49:24AM -0400, Paul Gortmaker wrote:
> On 14-03-08 03:07 AM, kbuild test robot wrote:
> > tree:   git://git.kernel.org/pub/scm/linux/kernel/git/benh/powerpc.git next
> > head:   c7e64b9ce04aa2e3fad7396d92b5cb92056d16ac
> > commit: 3c8464a9b12bf83807b6e2c896d7e7b633e1cae7 [45/53] powerpc: Delete old PrPMC 280/2800 support
> > config: make ARCH=powerpc c2k_defconfig
> > 
> > All warnings:
> > 
> > warning: (PPC_C2K && AMIGAONE) selects NOT_COHERENT_CACHE which has unmet direct dependencies (4xx || 8xx || E200 || PPC_MPC512x || GAMECUBE_COMMON)
> 
> This _looks_ like a new warning, but it really is not.  If you look
> at the tree prior to the above named commit, it generates this:
> 
> $ make c2k_defconfig
> warning: (PPC_PRPMC2800 && PPC_C2K && AMIGAONE) selects NOT_COHERENT_CACHE which has unmet direct dependencies (4xx || 8xx || E200 || PPC_MPC512x || GAMECUBE_COMMON)
> warning: (PPC_PRPMC2800 && PPC_C2K && AMIGAONE) selects NOT_COHERENT_CACHE which has unmet direct dependencies (4xx || 8xx || E200 || PPC_MPC512x || GAMECUBE_COMMON)
> #
> # configuration written to .config
> 
> So the warning is slightly different in text, but essentially
> the exact same thing that was being warned about before.  We've
> just removed one of the possible symbols from existence.

Yes, sorry, the kbuild robot is not smart enough to detect such
slightly changed error/warnings and will treat them as new ones.

> I'm not sure there would ever be a way to teach kbuild robot
> about something as subtle as the above; just one of the false
> positives that we'll have to live with, probably.

It is false positive: "this bug is not introduced by me!"

However if you take a broader view, it's still notifying the possibly
"relevant" people who may know the background about that bug, or whom
to further CC the report. :)

Thanks,
Fengguang

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [powerpc:next 45/53] warning: (PPC_C2K && ..) selects NOT_COHERENT_CACHE which has unmet direct dependencies (4xx || ..)
  2014-03-11  4:54   ` [powerpc:next 45/53] warning: (PPC_C2K && ..) selects NOT_COHERENT_CACHE which has unmet direct dependencies (4xx || ..) Fengguang Wu
@ 2014-03-11 14:32     ` Paul Gortmaker
  2014-03-11 23:30       ` Fengguang Wu
  0 siblings, 1 reply; 3+ messages in thread
From: Paul Gortmaker @ 2014-03-11 14:32 UTC (permalink / raw)
  To: Fengguang Wu; +Cc: Benjamin Herrenschmidt, kbuild-all, LKML

On 14-03-11 12:54 AM, Fengguang Wu wrote:
> On Mon, Mar 10, 2014 at 10:49:24AM -0400, Paul Gortmaker wrote:
>> On 14-03-08 03:07 AM, kbuild test robot wrote:
>>> tree:   git://git.kernel.org/pub/scm/linux/kernel/git/benh/powerpc.git next
>>> head:   c7e64b9ce04aa2e3fad7396d92b5cb92056d16ac
>>> commit: 3c8464a9b12bf83807b6e2c896d7e7b633e1cae7 [45/53] powerpc: Delete old PrPMC 280/2800 support
>>> config: make ARCH=powerpc c2k_defconfig
>>>
>>> All warnings:
>>>
>>> warning: (PPC_C2K && AMIGAONE) selects NOT_COHERENT_CACHE which has unmet direct dependencies (4xx || 8xx || E200 || PPC_MPC512x || GAMECUBE_COMMON)
>>
>> This _looks_ like a new warning, but it really is not.  If you look
>> at the tree prior to the above named commit, it generates this:
>>
>> $ make c2k_defconfig
>> warning: (PPC_PRPMC2800 && PPC_C2K && AMIGAONE) selects NOT_COHERENT_CACHE which has unmet direct dependencies (4xx || 8xx || E200 || PPC_MPC512x || GAMECUBE_COMMON)
>> warning: (PPC_PRPMC2800 && PPC_C2K && AMIGAONE) selects NOT_COHERENT_CACHE which has unmet direct dependencies (4xx || 8xx || E200 || PPC_MPC512x || GAMECUBE_COMMON)
>> #
>> # configuration written to .config
>>
>> So the warning is slightly different in text, but essentially
>> the exact same thing that was being warned about before.  We've
>> just removed one of the possible symbols from existence.
> 
> Yes, sorry, the kbuild robot is not smart enough to detect such
> slightly changed error/warnings and will treat them as new ones.

No apology required.  I think we all appreciate the build test
coverage, and I saw your mail where you said you sent out ~60
reports yesterday- wow!

Thanks,
Paul.
--

> 
>> I'm not sure there would ever be a way to teach kbuild robot
>> about something as subtle as the above; just one of the false
>> positives that we'll have to live with, probably.
> 
> It is false positive: "this bug is not introduced by me!"
> 
> However if you take a broader view, it's still notifying the possibly
> "relevant" people who may know the background about that bug, or whom
> to further CC the report. :)
> 
> Thanks,
> Fengguang
> 

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [powerpc:next 45/53] warning: (PPC_C2K && ..) selects NOT_COHERENT_CACHE which has unmet direct dependencies (4xx || ..)
  2014-03-11 14:32     ` Paul Gortmaker
@ 2014-03-11 23:30       ` Fengguang Wu
  0 siblings, 0 replies; 3+ messages in thread
From: Fengguang Wu @ 2014-03-11 23:30 UTC (permalink / raw)
  To: Paul Gortmaker; +Cc: Benjamin Herrenschmidt, kbuild-all, LKML

On Tue, Mar 11, 2014 at 10:32:29AM -0400, Paul Gortmaker wrote:
> On 14-03-11 12:54 AM, Fengguang Wu wrote:
> > On Mon, Mar 10, 2014 at 10:49:24AM -0400, Paul Gortmaker wrote:
> >> On 14-03-08 03:07 AM, kbuild test robot wrote:
> >>> tree:   git://git.kernel.org/pub/scm/linux/kernel/git/benh/powerpc.git next
> >>> head:   c7e64b9ce04aa2e3fad7396d92b5cb92056d16ac
> >>> commit: 3c8464a9b12bf83807b6e2c896d7e7b633e1cae7 [45/53] powerpc: Delete old PrPMC 280/2800 support
> >>> config: make ARCH=powerpc c2k_defconfig
> >>>
> >>> All warnings:
> >>>
> >>> warning: (PPC_C2K && AMIGAONE) selects NOT_COHERENT_CACHE which has unmet direct dependencies (4xx || 8xx || E200 || PPC_MPC512x || GAMECUBE_COMMON)
> >>
> >> This _looks_ like a new warning, but it really is not.  If you look
> >> at the tree prior to the above named commit, it generates this:
> >>
> >> $ make c2k_defconfig
> >> warning: (PPC_PRPMC2800 && PPC_C2K && AMIGAONE) selects NOT_COHERENT_CACHE which has unmet direct dependencies (4xx || 8xx || E200 || PPC_MPC512x || GAMECUBE_COMMON)
> >> warning: (PPC_PRPMC2800 && PPC_C2K && AMIGAONE) selects NOT_COHERENT_CACHE which has unmet direct dependencies (4xx || 8xx || E200 || PPC_MPC512x || GAMECUBE_COMMON)
> >> #
> >> # configuration written to .config
> >>
> >> So the warning is slightly different in text, but essentially
> >> the exact same thing that was being warned about before.  We've
> >> just removed one of the possible symbols from existence.
> > 
> > Yes, sorry, the kbuild robot is not smart enough to detect such
> > slightly changed error/warnings and will treat them as new ones.
> 
> No apology required.  I think we all appreciate the build test
> coverage, and I saw your mail where you said you sent out ~60
> reports yesterday- wow!

Paul, thank you!  But let me clarify it a bit.

The kernel test robots typically send out 30+ reports per day,
including build/boot error/warnings, performance/power/functional
regressions, and build test completion notifications.

The ~60 emails I mentioned are the ones that I write up in mutt,
most of them are on internal development and maintenance works of
the test infrastructure.

Thanks,
Fengguang

> Thanks,
> Paul.
> --
> 
> > 
> >> I'm not sure there would ever be a way to teach kbuild robot
> >> about something as subtle as the above; just one of the false
> >> positives that we'll have to live with, probably.
> > 
> > It is false positive: "this bug is not introduced by me!"
> > 
> > However if you take a broader view, it's still notifying the possibly
> > "relevant" people who may know the background about that bug, or whom
> > to further CC the report. :)
> > 
> > Thanks,
> > Fengguang
> > 

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2014-03-11 23:30 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
     [not found] <531acfa5.YesaRIJhSRvrw4/w%fengguang.wu@intel.com>
     [not found] ` <531DD0F4.6020000@windriver.com>
2014-03-11  4:54   ` [powerpc:next 45/53] warning: (PPC_C2K && ..) selects NOT_COHERENT_CACHE which has unmet direct dependencies (4xx || ..) Fengguang Wu
2014-03-11 14:32     ` Paul Gortmaker
2014-03-11 23:30       ` Fengguang Wu

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).