From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753442AbaCLMso (ORCPT ); Wed, 12 Mar 2014 08:48:44 -0400 Received: from mail-we0-f175.google.com ([74.125.82.175]:43433 "EHLO mail-we0-f175.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751227AbaCLMsm (ORCPT ); Wed, 12 Mar 2014 08:48:42 -0400 Date: Wed, 12 Mar 2014 12:48:35 +0000 From: Lee Jones To: Mark Rutland Cc: "linux-arm-kernel@lists.infradead.org" , "linux-kernel@vger.kernel.org" , "DCG_UPD_stlinux_kernel@list.st.com" , "devicetree@vger.kernel.org" , Srinivas Kandagatla Subject: Re: [PATCH v2 1/3] ata: ahci_st: Provide DT bindings for ST's SATA implementation Message-ID: <20140312124835.GA22450@lee--X1> References: <1393328481-7251-1-git-send-email-lee.jones@linaro.org> <20140312114257.GA17461@e106331-lin.cambridge.arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20140312114257.GA17461@e106331-lin.cambridge.arm.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > > +This binding describes a SATA device. > > + > > +Required properties: > > + - compatible : Must be "st,ahci" > > Is there not a more specific name? This is awfully generic. There isn't one. ST only have one AHCI driver. The driver is named as generically. > > + - reg : Physical base addresses and length of register sets > > + - interrupts : Interrupt associated with the SATA device > > + - interrupt-names : Associated name must be; "hostc" > > + - resets : The power-down and soft-reset lines of SATA IP > > + - reset-names : Associated names must be; "pwr-dwn" and "sw-rst" > > Get rid of the semicolon, it makes this harder to read. Same for the > other -names proeprties. Sure. > > + - clocks : The phandle for the clock > > + - clock-names : Associated name must be; "ahci_clk" > > + - phys : The phandle for the PHY device > > + - phy-names : Associated name must be; "ahci_phy" > > This looks sane, but I'd like to see a more specific description and > compatible string. Specific description in what sense? "This binding describes a SATA device." to "This binding describes ST's SATA device." ? > > +Example: > > + > > + sata0: sata@fe380000 { > > + compatible = "st,ahci"; > > + reg = <0xfe380000 0x1000>; > > + interrupts = ; > > + interrupt-names = "hostc"; > > + phys = <&miphy365x_phy MIPHY_PORT_0 MIPHY_TYPE_SATA>; > > + phy-names = "ahci_phy"; > > + resets = <&powerdown STIH416_SATA0_POWERDOWN>, > > + <&softreset STIH416_SATA0_SOFTRESET>; > > + reset-names = "pwr-dwn", "sw-rst"; > > + clocks = <&CLK_S_ICN_REG_0>; > > + clock-names = "ahci_clk"; > > + }; -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog