From: Maxime Ripard <maxime.ripard@free-electrons.com>
To: Hans de Goede <hdegoede@redhat.com>
Cc: Thomas Gleixner <tglx@linutronix.de>,
linux-arm-kernel@lists.infradead.org,
devicetree <devicetree@vger.kernel.org>,
linux-kernel@vger.kernel.org, linux-sunxi@googlegroups.com
Subject: Re: [PATCH v2 2/4] irqchip: sun4i: Fix irq 0 not working
Date: Thu, 13 Mar 2014 10:29:17 +0100 [thread overview]
Message-ID: <20140313092917.GE2815@lukather> (raw)
In-Reply-To: <1394644627-12315-3-git-send-email-hdegoede@redhat.com>
[-- Attachment #1: Type: text/plain, Size: 672 bytes --]
On Wed, Mar 12, 2014 at 06:17:05PM +0100, Hans de Goede wrote:
> SUN4I_IRQ_VECTOR_REG containing 0 can mean one of 3 things:
> 1) no more irqs pending
> 2) irq 0 pending
> 3) spurious irq
>
> So if we immediately get a reading of 0, check the irq-pending reg
> to differentiate between 2 and 3. We only do this once to avoid
> the extra check in the common case of 1) hapening after having
> read the vector-reg once.
>
> Signed-off-by: Hans de Goede <hdegoede@redhat.com>
Acked-by: Maxime Ripard <maxime.ripard@free-electrons.com>
Maxime
--
Maxime Ripard, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
next prev parent reply other threads:[~2014-03-13 9:30 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-12 17:17 [PATCH v2 0/4] irq: sun4i IRQ 0 / ENMI fixes Hans de Goede
2014-03-12 17:17 ` [PATCH v2 1/4] irq: Add handle_fasteoi_late_irq irq handler Hans de Goede
2014-03-12 17:21 ` Hans de Goede
2014-03-12 17:17 ` [PATCH v2 2/4] irqchip: sun4i: Fix irq 0 not working Hans de Goede
2014-03-13 9:29 ` Maxime Ripard [this message]
2014-03-12 17:17 ` [PATCH v2 3/4] irqchip: sun4i: Fix a comment about mask register initialization Hans de Goede
2014-03-12 17:17 ` [PATCH v2 4/4] irqchip: sun4i: Use handle_fasteoi_late_irq for the ENMI (irq 0) Hans de Goede
2014-03-13 9:34 ` Maxime Ripard
2014-03-13 9:56 ` [linux-sunxi] " Carlo Caione
2014-03-13 11:12 ` Thomas Gleixner
2014-03-13 15:09 ` Hans de Goede
2014-03-13 14:46 ` Thomas Gleixner
2014-03-13 15:13 ` Hans de Goede
2014-03-13 16:27 ` Thomas Gleixner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140313092917.GE2815@lukather \
--to=maxime.ripard@free-electrons.com \
--cc=devicetree@vger.kernel.org \
--cc=hdegoede@redhat.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sunxi@googlegroups.com \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox