From: Mike Snitzer <snitzer@redhat.com>
To: Christoph Hellwig <hch@infradead.org>
Cc: Hannes Reinecke <hare@suse.de>, Jeff Moyer <jmoyer@redhat.com>,
Jens Axboe <axboe@kernel.dk>, Shaohua Li <shli@fusionio.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 1/1] block: rework flush sequencing for blk-mq
Date: Thu, 13 Mar 2014 12:13:47 -0400 [thread overview]
Message-ID: <20140313161347.GA6598@redhat.com> (raw)
In-Reply-To: <20140312102849.GA26509@infradead.org>
On Wed, Mar 12 2014 at 6:28am -0400,
Christoph Hellwig <hch@infradead.org> wrote:
> On Sat, Mar 08, 2014 at 08:51:18PM +0100, Hannes Reinecke wrote:
> > Hey, calm down.
> > I've made the fix just two days ago. And was quite surprised that
> > I've been the first hitting that; should've crashed for everybody
> > using dm-multipath.
> > And given the pushback I've gotten recently from patches I would
> > have thought that it would work for most users; sure the author
> > would've done due diligence on the original patchset ...
>
> There's very little testing of dm-multipath for upstream work, as I've
> seen tons of avoidable breakage. Doesn't help that it uses a special
> code path that one else uses.
Pretty ironic that in the same email that you ask someone to "Let's make
this a little less personal." you start by asserting upstream
dm-multipath sees very little testing -- and use your commit that
recently broke dm-multipath as the basis. Anyway, please exapnd on what
you feel is broken with upstream dm-multipath.
And please be specific about whether it is SCSI/block or dm-multipath
code that has regressed.
> > BTW, it not _my_ decision to sit on tons of SUSE specific patches.
> > I really try to get things upstream. But I cannot do more than
> > sending patches upstream, answer patiently any questions, and redo
> > the patchset.
> > Which I did. Frequently, But, alas, it's up to the maintainer to
> > apply them. And I can only ask and hope. The usual story...
>
> Let's make this a little less personal. Fact is that the SuSE trees
> have tons of patches in there that never have even been sent upstream.
> There's also tons that have been posted once or twice. While I feel
> your frustration with the SCSI process fully and we'll need to work on
> that somehow, how about you do another round of dumping the DM patches
> on the dm-devel list and Mike?
>
> I'll ping some of the other worst offenders as time permits.
>
next prev parent reply other threads:[~2014-03-13 16:14 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-30 13:26 [PATCH 0/1] block: rework flush sequencing for blk-mq Christoph Hellwig
2014-01-30 13:26 ` [PATCH 1/1] " Christoph Hellwig
2014-02-07 1:18 ` Shaohua Li
2014-02-07 14:19 ` Christoph Hellwig
2014-02-08 0:55 ` Shaohua Li
2014-02-10 10:33 ` Christoph Hellwig
2014-03-07 20:45 ` Jeff Moyer
2014-03-08 15:52 ` Christoph Hellwig
2014-03-08 17:33 ` Mike Snitzer
2014-03-08 19:51 ` Hannes Reinecke
2014-03-08 18:13 ` Mike Snitzer
2014-03-08 21:33 ` Hannes Reinecke
2014-03-08 22:09 ` [PATCH] block: fix q->flush_rq NULL pointer crash on dm-mpath flush Mike Snitzer
2014-03-09 0:24 ` Jens Axboe
2014-03-09 0:57 ` Mike Snitzer
2014-03-09 3:18 ` Jens Axboe
2014-03-09 3:29 ` Mike Snitzer
2014-03-12 10:28 ` [PATCH 1/1] block: rework flush sequencing for blk-mq Christoph Hellwig
2014-03-12 10:50 ` Hannes Reinecke
2014-03-12 10:55 ` Christoph Hellwig
2014-03-12 11:07 ` Hannes Reinecke
2014-03-12 11:00 ` SuSE O_DIRECT|O_NONBLOCK overload Christoph Hellwig
2014-03-13 0:15 ` NeilBrown
2014-03-14 17:46 ` Mike Christie
2014-03-13 16:13 ` Mike Snitzer [this message]
2014-03-14 9:25 ` [PATCH 1/1] block: rework flush sequencing for blk-mq Christoph Hellwig
2014-03-14 9:30 ` Hannes Reinecke
2014-03-14 12:44 ` Christoph Hellwig
2014-03-14 9:34 ` Christoph Hellwig
2014-03-14 9:52 ` Hannes Reinecke
2014-03-14 10:58 ` Christoph Hellwig
2014-03-14 11:10 ` Hannes Reinecke
2014-03-14 13:00 ` Mike Snitzer
2014-03-14 13:23 ` Christoph Hellwig
2014-03-14 14:13 ` Mike Snitzer
2014-03-15 13:28 ` scsi_debug and mutipath, was " Christoph Hellwig
2014-03-17 11:55 ` [dm-devel] " Bryn M. Reeves
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140313161347.GA6598@redhat.com \
--to=snitzer@redhat.com \
--cc=axboe@kernel.dk \
--cc=hare@suse.de \
--cc=hch@infradead.org \
--cc=jmoyer@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=shli@fusionio.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).