From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755180AbaCMWrW (ORCPT ); Thu, 13 Mar 2014 18:47:22 -0400 Received: from mail-wi0-f170.google.com ([209.85.212.170]:49976 "EHLO mail-wi0-f170.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755088AbaCMWrU (ORCPT ); Thu, 13 Mar 2014 18:47:20 -0400 Date: Thu, 13 Mar 2014 22:47:15 +0000 From: Lee Jones To: Peter Tyser Cc: linux-kernel@vger.kernel.org, Guenter Roeck , James Ralston , Samuel Ortiz , Wim Van Sebroeck , linux-watchdog@vger.kernel.org Subject: Re: [PATCH 4/8] mfd: lpc_ich: Add support for iTCO v3 Message-ID: <20140313224715.GF28504@lee--X1> References: <1394487298-14459-1-git-send-email-ptyser@xes-inc.com> <1394487298-14459-4-git-send-email-ptyser@xes-inc.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1394487298-14459-4-git-send-email-ptyser@xes-inc.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > Some newer Atom CPUs, eg Avoton and Bay Trail, use slightly different > register layouts for the iTCO than the current v1 and v2 iTCO. > Differences from previous iTCO versions include: > - The ACPI space is enabled in the "ACPI base address" register instead > of the "ACPI control register" > > - The "no reboot" functionality is set in the "Power Management > Configuration" register instead of the "General Control and Status" > (GCS) register or PCI configuration space. > > - The "ACPI Control Register" is not present on v3. The "Power > Management Configuration Base Address" register resides at the same > address is Avoton/Bay Trail. > > To differentiate these newer chipsets create a new v3 iTCO version and > update the MFD driver to support them. > > Signed-off-by: Peter Tyser > Tested-by: Rajat Jain > Cc: Guenter Roeck > Cc: James Ralston > Cc: Samuel Ortiz > Cc: Lee Jones > Cc: Wim Van Sebroeck > Cc: linux-watchdog@vger.kernel.org > --- > drivers/mfd/lpc_ich.c | 81 +++++++++++++++++++++++++++++++++++------- > include/linux/mfd/lpc_ich.h | 8 ++-- > 2 files changed, 71 insertions(+), 18 deletions(-) Applied with Guenter's Reviewed-by. -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog