From: Borislav Petkov <bp@alien8.de>
To: Daniel J Blueman <daniel@numascale.com>
Cc: Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>, "H. Peter Anvin" <hpa@zytor.com>,
x86@kernel.org, Borislav Petkov <bp@suse.de>,
linux-kernel@vger.kernel.org, Steffen Persvold <sp@numascale.com>
Subject: Re: [PATCH] Fix northbridge quirk to assign correct NUMA node
Date: Fri, 14 Mar 2014 10:06:17 +0100 [thread overview]
Message-ID: <20140314090617.GA4697@pd.tnic> (raw)
In-Reply-To: <1394710981-3596-1-git-send-email-daniel@numascale.com>
On Thu, Mar 13, 2014 at 07:43:01PM +0800, Daniel J Blueman wrote:
> For systems with multiple servers and routed fabric, all northbridges get
> assigned to the first server. Fix this by also using the node reported from
> the PCI bus. For single-fabric systems, the northbriges are on PCI bus 0
> by definition, which are on NUMA node 0 by definition, so this is invarient
> on most systems.
Yeah, I think this is of very low risk for !Numascale setups. :-) So
Acked-by: Borislav Petkov <bp@suse.de>
> Tested on fam10h and fam15h single and multi-fabric systems and candidate
> for stable.
I'm not sure about it - this is only reporting the wrong node, right?
Does anything depend on that node setting being correct and breaks due
to this?
Thanks.
--
Regards/Gruss,
Boris.
Sent from a fat crate under my desk. Formatting is fine.
--
next prev parent reply other threads:[~2014-03-14 9:06 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-13 11:43 [PATCH] Fix northbridge quirk to assign correct NUMA node Daniel J Blueman
2014-03-14 9:06 ` Borislav Petkov [this message]
2014-03-14 9:57 ` Daniel J Blueman
2014-03-14 10:09 ` [tip:x86/urgent] x86/amd/numa: " tip-bot for Daniel J Blueman
2014-03-20 22:07 ` [PATCH] " Bjorn Helgaas
2014-03-21 3:38 ` Daniel J Blueman
2014-03-21 16:11 ` Bjorn Helgaas
2014-03-24 6:03 ` Daniel J Blueman
2014-03-21 17:16 ` Suravee Suthikulpanit
2014-03-23 14:30 ` Daniel J Blueman
2014-03-21 3:51 ` Suravee Suthikulpanit
2014-03-21 4:14 ` Daniel J Blueman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140314090617.GA4697@pd.tnic \
--to=bp@alien8.de \
--cc=bp@suse.de \
--cc=daniel@numascale.com \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=sp@numascale.com \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox