From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755508AbaCNOQ0 (ORCPT ); Fri, 14 Mar 2014 10:16:26 -0400 Received: from mail-yh0-f53.google.com ([209.85.213.53]:34942 "EHLO mail-yh0-f53.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754786AbaCNOQS (ORCPT ); Fri, 14 Mar 2014 10:16:18 -0400 Date: Fri, 14 Mar 2014 11:16:12 -0300 From: Arnaldo Carvalho de Melo To: Jiri Olsa Cc: linux-kernel@vger.kernel.org, Don Zickus , Corey Ashford , Adrian Hunter , David Ahern , Frederic Weisbecker , Ingo Molnar , Namhyung Kim , Paul Mackerras , Peter Zijlstra Subject: Re: [PATCH 4/5] perf tools: Add machine pointer into thread struct Message-ID: <20140314141612.GE2396@ghostprotocols.net> References: <1394805606-25883-1-git-send-email-jolsa@redhat.com> <1394805606-25883-5-git-send-email-jolsa@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1394805606-25883-5-git-send-email-jolsa@redhat.com> X-Url: http://acmel.wordpress.com User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Em Fri, Mar 14, 2014 at 03:00:05PM +0100, Jiri Olsa escreveu: > Need machine pointer in thread object, so we could > lookup the process thread in following patch. Can't we use the already existing thread->mg.machine for that? - Arnaldo > Signed-off-by: Jiri Olsa > Cc: Don Zickus > Cc: Corey Ashford > Cc: David Ahern > Cc: Frederic Weisbecker > Cc: Ingo Molnar > Cc: Namhyung Kim > Cc: Paul Mackerras > Cc: Peter Zijlstra > Cc: Arnaldo Carvalho de Melo > --- > tools/perf/util/machine.c | 2 +- > tools/perf/util/thread.c | 4 +++- > tools/perf/util/thread.h | 5 ++++- > 3 files changed, 8 insertions(+), 3 deletions(-) > > diff --git a/tools/perf/util/machine.c b/tools/perf/util/machine.c > index 009dfb4..6196bb9 100644 > --- a/tools/perf/util/machine.c > +++ b/tools/perf/util/machine.c > @@ -311,7 +311,7 @@ static struct thread *__machine__findnew_thread(struct machine *machine, > if (!create) > return NULL; > > - th = thread__new(pid, tid); > + th = thread__new(pid, tid, machine); > if (th != NULL) { > rb_link_node(&th->rb_node, parent, p); > rb_insert_color(&th->rb_node, &machine->threads); > diff --git a/tools/perf/util/thread.c b/tools/perf/util/thread.c > index ac77b6c..7c1aad0 100644 > --- a/tools/perf/util/thread.c > +++ b/tools/perf/util/thread.c > @@ -8,13 +8,15 @@ > #include "debug.h" > #include "comm.h" > > -struct thread *thread__new(pid_t pid, pid_t tid) > +struct thread *thread__new(pid_t pid, pid_t tid, > + struct machine *machine) > { > char *comm_str; > struct comm *comm; > struct thread *thread = zalloc(sizeof(*thread)); > > if (thread != NULL) { > + thread->machine = machine; > thread->pid_ = pid; > thread->tid = tid; > thread->ppid = -1; > diff --git a/tools/perf/util/thread.h b/tools/perf/util/thread.h > index 77d0be2..2200557 100644 > --- a/tools/perf/util/thread.h > +++ b/tools/perf/util/thread.h > @@ -7,12 +7,14 @@ > #include > #include "symbol.h" > #include > +#include "machine.h" > > struct thread { > union { > struct rb_node rb_node; > struct list_head node; > }; > + struct machine *machine; > struct map_groups *mg; > pid_t pid_; /* Not all tools update this */ > pid_t tid; > @@ -29,7 +31,8 @@ struct thread { > struct machine; > struct comm; > > -struct thread *thread__new(pid_t pid, pid_t tid); > +struct thread *thread__new(pid_t pid, pid_t tid, > + struct machine *machine); > void thread__delete(struct thread *thread); > static inline void thread__exited(struct thread *thread) > { > -- > 1.8.3.1