From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754962AbaCNPIy (ORCPT ); Fri, 14 Mar 2014 11:08:54 -0400 Received: from cantor2.suse.de ([195.135.220.15]:33879 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753432AbaCNPIx (ORCPT ); Fri, 14 Mar 2014 11:08:53 -0400 Date: Fri, 14 Mar 2014 16:08:50 +0100 From: Jan Kara To: Tejun Heo Cc: Jan Kara , Roman Peniaev , Andrew Morton , Alexander Viro , linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, Jens Axboe Subject: Re: [PATCH 1/1] fs/mpage.c: forgotten WRITE_SYNC in case of data integrity write Message-ID: <20140314150850.GA5175@quack.suse.cz> References: <20140313200119.GB504@quack.suse.cz> <20140313143456.157404fd7f208638ca70e317@linux-foundation.org> <20140314130712.GC12613@htj.dyndns.org> <20140314141143.GH12613@htj.dyndns.org> <20140314141511.GF18583@quack.suse.cz> <20140314145215.GG18583@quack.suse.cz> <20140314145430.GL12613@htj.dyndns.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20140314145430.GL12613@htj.dyndns.org> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri 14-03-14 10:54:30, Tejun Heo wrote: > On Fri, Mar 14, 2014 at 03:52:15PM +0100, Jan Kara wrote: > > Well, for ext2, you can use ext4 kernel driver which takes care of > > REQ_FLUSH properly. For fat, you'll need to fix the fs... > > This is a bit surprising tho. Were we always like this? We never had > even stupid "flush down everything and sync"? Or is this something we > broke while morphing flush implementation several times in the past > years? It has been always like this. We could add some sending of REQ_FLUSH into generic code - like generic_file_fsync() and some similar helper for ->sync_fs(). Just someone has to do it... Honza -- Jan Kara SUSE Labs, CR