From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756100AbaCNQRu (ORCPT ); Fri, 14 Mar 2014 12:17:50 -0400 Received: from mga11.intel.com ([192.55.52.93]:62007 "EHLO mga11.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755092AbaCNQRq (ORCPT ); Fri, 14 Mar 2014 12:17:46 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="4.97,655,1389772800"; d="scan'208";a="498632092" Date: Fri, 14 Mar 2014 09:17:45 -0700 From: Andi Kleen To: Venkatesh Srinivas Cc: Peter Zijlstra , linux-kernel@vger.kernel.org, Stephane Eranian , mingo@elte.hu, zheng.z.yan@intel.com Subject: Re: [PATCH] perf/x86/intel: Use rdmsrl_safe when initializing RAPL PMU. Message-ID: <20140314161745.GH3793@tassilo.jf.intel.com> References: <1394739386-22260-1-git-send-email-venkateshs@google.com> <20140314084429.GO27965@twins.programming.kicks-ass.net> <20140314135652.GE3793@tassilo.jf.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > The Intel ISR section for RDMSR seems to say: "Specifying a reserved > or unimplemented > MSR address in ECX will also cause a general protection exception". > > From a guest's perspective, MSR_RAPL_POWER_UNIT is unimplemented; kvm matches > this behavior. MSRs are model specific and defined per model number. If you report a model number you're expected to implement the MSRs defined for that model number. AFAIK Xen just reports 0 for unknown MSRs (and I'm surprised KVM doesn't too) I would suggest to fix KVM. -Andi