From: Greg KH <gregkh@linuxfoundation.org>
To: Davide Berardi <berardi.dav@gmail.com>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH] fixing some coding style issues on line6 driver.c
Date: Sun, 16 Mar 2014 16:37:00 +0000 [thread overview]
Message-ID: <20140316163700.GA1781@kroah.com> (raw)
In-Reply-To: <20140316132016.388a3f69@White-Rabbit>
On Sun, Mar 16, 2014 at 01:20:16PM +0100, Davide Berardi wrote:
> Fixed some over-80 characters lines.
> (this is for eudyptula challenge task 10).
>
> From: Davide Berardi <berardi.dav@gmail.com>
>
> Signed-off-by: Davide Berardi <berardi.dav@gmail.com>
> ---
> diff --git a/drivers/staging/line6/driver.c b/drivers/staging/line6/driver.c
> index e7a9d8d..b3652e6 100644
> --- a/drivers/staging/line6/driver.c
> +++ b/drivers/staging/line6/driver.c
> @@ -59,26 +59,46 @@ MODULE_DEVICE_TABLE(usb, line6_id_table);
>
> /* *INDENT-OFF* */
> static struct line6_properties line6_properties_table[] = {
> - { LINE6_BIT_BASSPODXT, "BassPODxt", "BassPODxt", LINE6_BIT_CONTROL_PCM_HWMON },
> - { LINE6_BIT_BASSPODXTLIVE, "BassPODxtLive", "BassPODxt Live", LINE6_BIT_CONTROL_PCM_HWMON },
> - { LINE6_BIT_BASSPODXTPRO, "BassPODxtPro", "BassPODxt Pro", LINE6_BIT_CONTROL_PCM_HWMON },
> - { LINE6_BIT_GUITARPORT, "GuitarPort", "GuitarPort", LINE6_BIT_PCM },
> - { LINE6_BIT_POCKETPOD, "PocketPOD", "Pocket POD", LINE6_BIT_CONTROL },
> - { LINE6_BIT_PODHD300, "PODHD300", "POD HD300", LINE6_BIT_CONTROL_PCM_HWMON },
> - { LINE6_BIT_PODHD400, "PODHD400", "POD HD400", LINE6_BIT_CONTROL_PCM_HWMON },
> - { LINE6_BIT_PODHD500, "PODHD500", "POD HD500", LINE6_BIT_CONTROL_PCM_HWMON },
> - { LINE6_BIT_PODSTUDIO_GX, "PODStudioGX", "POD Studio GX", LINE6_BIT_PCM },
> - { LINE6_BIT_PODSTUDIO_UX1, "PODStudioUX1", "POD Studio UX1", LINE6_BIT_PCM },
> - { LINE6_BIT_PODSTUDIO_UX2, "PODStudioUX2", "POD Studio UX2", LINE6_BIT_PCM },
> - { LINE6_BIT_PODX3, "PODX3", "POD X3", LINE6_BIT_PCM },
> - { LINE6_BIT_PODX3LIVE, "PODX3Live", "POD X3 Live", LINE6_BIT_PCM },
> - { LINE6_BIT_PODXT, "PODxt", "PODxt", LINE6_BIT_CONTROL_PCM_HWMON },
> - { LINE6_BIT_PODXTLIVE, "PODxtLive", "PODxt Live", LINE6_BIT_CONTROL_PCM_HWMON },
> - { LINE6_BIT_PODXTPRO, "PODxtPro", "PODxt Pro", LINE6_BIT_CONTROL_PCM_HWMON },
> - { LINE6_BIT_TONEPORT_GX, "TonePortGX", "TonePort GX", LINE6_BIT_PCM },
> - { LINE6_BIT_TONEPORT_UX1, "TonePortUX1", "TonePort UX1", LINE6_BIT_PCM },
> - { LINE6_BIT_TONEPORT_UX2, "TonePortUX2", "TonePort UX2", LINE6_BIT_PCM },
> - { LINE6_BIT_VARIAX, "Variax", "Variax Workbench", LINE6_BIT_CONTROL },
> + { LINE6_BIT_BASSPODXT, "BassPODxt",
> + "BassPODxt", LINE6_BIT_CONTROL_PCM_HWMON },
> + { LINE6_BIT_BASSPODXTLIVE, "BassPODxtLive",
> + "BassPODxt Live", LINE6_BIT_CONTROL_PCM_HWMON },
That looks worse, sorry, I can't take this.
greg k-h
next prev parent reply other threads:[~2014-03-16 16:35 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-16 12:20 [PATCH] fixing some coding style issues on line6 driver.c Davide Berardi
2014-03-16 16:37 ` Greg KH [this message]
2014-03-16 16:55 ` Joe Perches
2014-03-17 2:34 ` Davide Berardi
2014-03-17 19:08 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140316163700.GA1781@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=berardi.dav@gmail.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).