public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Cyrill Gorcunov <gorcunov@gmail.com>
To: Pavel Emelyanov <xemul@parallels.com>
Cc: Andrey Vagin <avagin@openvz.org>,
	linux-kernel@vger.kernel.org, criu@openvz.org,
	Al Viro <viro@zeniv.linux.org.uk>,
	Oleg Nesterov <oleg@redhat.com>,
	Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [PATCH] proc: show mnt_id in fdinfo files
Date: Mon, 17 Mar 2014 15:50:13 +0400	[thread overview]
Message-ID: <20140317115013.GA26250@moon> (raw)
In-Reply-To: <5326DCD2.1040303@parallels.com>

On Mon, Mar 17, 2014 at 03:30:26PM +0400, Pavel Emelyanov wrote:
> On 03/17/2014 02:39 PM, Andrey Vagin wrote:
> > Currently we don't have a way how to determing from which mount point
> > file has been opened. This information is required for proper dumping
> > and restoring file descriptos due to presence of mount namespaces. It's
> > possible, that two file descriptors are opened using the same paths, but
> > one fd references mount point from one namespace while the other fd --
> > from other namespace.
> > 
> > Cc: Al Viro <viro@zeniv.linux.org.uk>
> > Cc: Oleg Nesterov <oleg@redhat.com>
> > Cc: Andrew Morton <akpm@linux-foundation.org>
> > Cc: Cyrill Gorcunov <gorcunov@openvz.org>
> > Cc: Pavel Emelyanov <xemul@parallels.com>
> > Signed-off-by: Andrey Vagin <avagin@openvz.org>
> 
> These IDs are already shown in the /proc/$pid/mountinfo, and for some FSs
> can be obtained via path_to_handle_at(), so this patch just makes it work
> for any FS and speeds things up.
> 
> Acked-by: Pavel Emelyanov <xemul@parallels.com>

I think Documentation/filesystems/proc.txt should be updated on top.
Other than that

Reviewed-by: Cyrill Gorcunov <gorcunov@openvz.org>

  reply	other threads:[~2014-03-17 11:50 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-03-17 10:39 [PATCH] proc: show mnt_id in fdinfo files Andrey Vagin
2014-03-17 11:30 ` Pavel Emelyanov
2014-03-17 11:50   ` Cyrill Gorcunov [this message]
2014-03-19 23:22     ` Andrew Morton

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140317115013.GA26250@moon \
    --to=gorcunov@gmail.com \
    --cc=akpm@linux-foundation.org \
    --cc=avagin@openvz.org \
    --cc=criu@openvz.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=oleg@redhat.com \
    --cc=viro@zeniv.linux.org.uk \
    --cc=xemul@parallels.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox