From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932464AbaCQSFf (ORCPT ); Mon, 17 Mar 2014 14:05:35 -0400 Received: from service87.mimecast.com ([91.220.42.44]:38666 "EHLO service87.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756897AbaCQSFa convert rfc822-to-8bit (ORCPT ); Mon, 17 Mar 2014 14:05:30 -0400 Date: Mon, 17 Mar 2014 18:05:25 +0000 From: Liviu Dudau To: Catalin Marinas Cc: Arnd Bergmann , linux-pci , Bjorn Helgaas , Will Deacon , Benjamin Herrenschmidt , linaro-kernel , LKML , "devicetree@vger.kernel.org" , LAKML , Tanmay Inamdar , Grant Likely Subject: Re: [PATCH v7 3/3] arm64: Add architecture support for PCI Message-ID: <20140317180525.GL6457@e106497-lin.cambridge.arm.com> Mail-Followup-To: Catalin Marinas , Arnd Bergmann , linux-pci , Bjorn Helgaas , Will Deacon , Benjamin Herrenschmidt , linaro-kernel , LKML , "devicetree@vger.kernel.org" , LAKML , Tanmay Inamdar , Grant Likely References: <1394811258-1500-1-git-send-email-Liviu.Dudau@arm.com> <1394811258-1500-4-git-send-email-Liviu.Dudau@arm.com> <20140314171457.GK18126@arm.com> <201403141838.08900.arnd@arndb.de> <20140314180527.GZ6457@e106497-lin.cambridge.arm.com> <20140317173821.GJ24070@arm.com> MIME-Version: 1.0 In-Reply-To: <20140317173821.GJ24070@arm.com> User-Agent: Mutt/1.5.22 (2013-10-16) X-OriginalArrivalTime: 17 Mar 2014 18:05:38.0795 (UTC) FILETIME=[80AD53B0:01CF420B] X-MC-Unique: 114031718052800301 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8BIT Content-Disposition: inline Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Mar 17, 2014 at 05:38:21PM +0000, Catalin Marinas wrote: > On Fri, Mar 14, 2014 at 06:05:27PM +0000, Liviu Dudau wrote: > > On Fri, Mar 14, 2014 at 05:38:08PM +0000, Arnd Bergmann wrote: > > > On Friday 14 March 2014, Catalin Marinas wrote: > > > > On Fri, Mar 14, 2014 at 03:34:18PM +0000, Liviu Dudau wrote: > > > > > --- /dev/null > > > > > +++ b/arch/arm64/kernel/pci.c > > > > [...] > > > > > +int pci_register_io_range(phys_addr_t address, resource_size_t size) > > > > [...] > > > > > +unsigned long pci_address_to_pio(phys_addr_t address) > > > > [...] > > > > > +void pcibios_fixup_bus(struct pci_bus *bus) > > > > [ actually most of this file ] > > > > > > > > Maybe it was raised before already but can we have __weak generic > > > > definitions of these functions? They don't seem to be arm64 specific in > > > > any way. > [...] > > Catalin, if you are happy to ask for ACKs from all arch maintainers that might get > > affected by our custom version of pci_address_to_pio() before you can pull PCI support > > for arm64 then I can propose a new patchset. > > You don't need to change the other architectures, that's the point of a > __weak definition, it will be automatically overridden. If you want, you > can even place a GENERIC_PCI or whatever config option that is only > selected by arm64 for the time being. pci_address_to_pio() is alread __weak. My patch was adding the arm64 version of it. Adding an #ifdef GENERIC_PCI to the __weak implementation is not just a temporary solution. We would still have to keep some sort of #ifdef around in the function as x86 will never pickup our version. Regardless, the list of people that would need to ACK that change will increase, right? Best regards, Liviu > > -- > Catalin > -- > To unsubscribe from this list: send the line "unsubscribe linux-pci" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html > -- ==================== | I would like to | | fix the world, | | but they're not | | giving me the | \ source code! / --------------- ¯\_(ツ)_/¯