From: Greg KH <gregkh@linuxfoundation.org>
To: Masood Mehmood <ody.guru@gmail.com>
Cc: lidza.louina@gmail.com, devel@driverdev.osuosl.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] staging: dgap: Fixed sparse error: same symbol redeclared with different type
Date: Mon, 17 Mar 2014 14:31:28 -0700 [thread overview]
Message-ID: <20140317213128.GA2147@kroah.com> (raw)
In-Reply-To: <1394355455-20644-1-git-send-email-ody.guru@gmail.com>
On Sun, Mar 09, 2014 at 12:57:35AM -0800, Masood Mehmood wrote:
> sparse reported dgap_do_fep_load is redeclared with different type. while
> fixing, I noticed __user attribute is used incorrectly in declaration.
> There is no need to define __user for firware->data.
>
> Replaced the __user with 'const uchar *' from function dgap_do_fep_load and
> did the same for function dgap_do_bios_load.
>
> Signed-off-by: Masood Mehmood <ody.guru@gmail.com>
> ---
> drivers/staging/dgap/dgap.c | 13 ++++++-------
> 1 file changed, 6 insertions(+), 7 deletions(-)
This patch does not apply to my tree, can you redo it?
thanks,
greg k-h
next prev parent reply other threads:[~2014-03-17 21:29 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-09 8:57 [PATCH] staging: dgap: Fixed sparse error: same symbol redeclared with different type Masood Mehmood
2014-03-17 21:31 ` Greg KH [this message]
-- strict thread matches above, loose matches on Subject: below --
2014-03-13 3:55 Masood Mehmood
2014-03-17 21:36 ` Greg KH
2014-03-13 10:02 Masood Mehmood
2014-03-18 20:05 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140317213128.GA2147@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=devel@driverdev.osuosl.org \
--cc=lidza.louina@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=ody.guru@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox