[PATCH] xen: declare notifier_block on xen-ops.h

[PATCH] xen: declare notifier_block on xen-ops.h

[Stanislaw Gruszka]

Patch fixes below warnings:

   In file included from arch/x86/xen/xen-ops.h:7:0,
                    from arch/x86/xen/vga.c:9:
>> include/xen/xen-ops.h:19:42: warning: 'struct notifier_block' declared inside parameter list [enabled by default]
    void xen_resume_notifier_register(struct notifier_block *nb);
                                             ^
>> include/xen/xen-ops.h:19:42: warning: its scope is only this definition or declaration, which is probably not what you want [enabled by default]
>> include/xen/xen-ops.h:20:44: warning: 'struct notifier_block' declared inside parameter list [enabled by default]
    void xen_resume_notifier_unregister(struct notifier_block *nb);

Signed-off-by: Stanislaw Gruszka <sgruszka@redhat.com>
---
 drivers/xen/manage.c  | 1 -
 include/xen/xen-ops.h | 1 +
 2 files changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/xen/manage.c b/drivers/xen/manage.c
index 96e4173..fc6c94c 100644
--- a/drivers/xen/manage.c
+++ b/drivers/xen/manage.c
@@ -13,7 +13,6 @@
 #include <linux/freezer.h>
 #include <linux/syscore_ops.h>
 #include <linux/export.h>
-#include <linux/notifier.h>
 
 #include <xen/xen.h>
 #include <xen/xenbus.h>
diff --git a/include/xen/xen-ops.h b/include/xen/xen-ops.h
index cc8b4cb..acc7b7a 100644
--- a/include/xen/xen-ops.h
+++ b/include/xen/xen-ops.h
@@ -2,6 +2,7 @@
 #define INCLUDE_XEN_OPS_H
 
 #include <linux/percpu.h>
+#include <linux/notifier.h>
 #include <asm/xen/interface.h>
 
 DECLARE_PER_CPU(struct vcpu_info *, xen_vcpu);
-- 
1.7.11.7

Re: [Xen-devel] [PATCH] xen: declare notifier_block on xen-ops.h

[David Vrabel]

On 17/03/14 07:48, Stanislaw Gruszka wrote:
> Patch fixes below warnings:
> 
>    In file included from arch/x86/xen/xen-ops.h:7:0,
>                     from arch/x86/xen/vga.c:9:
>>> include/xen/xen-ops.h:19:42: warning: 'struct notifier_block' declared inside parameter list [enabled by default]
>     void xen_resume_notifier_register(struct notifier_block *nb);
>                                              ^
>>> include/xen/xen-ops.h:19:42: warning: its scope is only this definition or declaration, which is probably not what you want [enabled by default]
>>> include/xen/xen-ops.h:20:44: warning: 'struct notifier_block' declared inside parameter list [enabled by default]
>     void xen_resume_notifier_unregister(struct notifier_block *nb);

Is this a fix up to your previous  "xen/acpi-processor: fix enabling
interrupts on syscore_resume" patch?  If so, do you mind if we squash
the two commits together?  So bisectability is improved.

David

Re: [Xen-devel] [PATCH] xen: declare notifier_block on xen-ops.h

[Stanislaw Gruszka]

On Mon, Mar 17, 2014 at 05:56:03PM +0000, David Vrabel wrote:
> On 17/03/14 07:48, Stanislaw Gruszka wrote:
> > Patch fixes below warnings:
> > 
> >    In file included from arch/x86/xen/xen-ops.h:7:0,
> >                     from arch/x86/xen/vga.c:9:
> >>> include/xen/xen-ops.h:19:42: warning: 'struct notifier_block' declared inside parameter list [enabled by default]
> >     void xen_resume_notifier_register(struct notifier_block *nb);
> >                                              ^
> >>> include/xen/xen-ops.h:19:42: warning: its scope is only this definition or declaration, which is probably not what you want [enabled by default]
> >>> include/xen/xen-ops.h:20:44: warning: 'struct notifier_block' declared inside parameter list [enabled by default]
> >     void xen_resume_notifier_unregister(struct notifier_block *nb);
> 
> Is this a fix up to your previous  "xen/acpi-processor: fix enabling
> interrupts on syscore_resume" patch? 
Yes.

> If so, do you mind if we squash
> the two commits together?  So bisectability is improved.
No problem with that (though I don't think actual build is broken
since we don't use xen_resume_notifier_register on .c files that
do not include linux/notifier.h directly or indirectly).
 
Thanks
Stanislaw