From: Peter Zijlstra <peterz@infradead.org>
To: "Paul E. McKenney" <paulmck@linux.vnet.ibm.com>
Cc: mingo@elte.hu, josh@joshtriplett.org, laijs@cn.fujitsu.com,
linux-kernel@vger.kernel.org
Subject: Re: cond_resched() and RCU CPU stall warnings
Date: Tue, 18 Mar 2014 09:51:18 +0100 [thread overview]
Message-ID: <20140318085118.GO25546@laptop.programming.kicks-ass.net> (raw)
In-Reply-To: <20140318021706.GE4420@linux.vnet.ibm.com>
On Mon, Mar 17, 2014 at 07:17:06PM -0700, Paul E. McKenney wrote:
> On Mon, Mar 17, 2014 at 06:14:34PM +0100, Peter Zijlstra wrote:
> > On Mon, Mar 17, 2014 at 09:58:07AM -0700, Paul E. McKenney wrote:
> > > @@ -4111,6 +4115,7 @@ int __sched __cond_resched_softirq(void)
> > > {
> > > BUG_ON(!in_softirq());
> > >
> > > + rcu_cond_resched();
> >
> > Don't you have to enable BHs before doing that? And if not; that needs a
> > comment for sure! :-)
>
> No need to enable BHs, just RCU marking quiescent states. But yes,
> the name does look a bit scary in that context, doesn't it? Added
> a comment, please see below for updated patch.
The below seemed like an unrelated patch entirely :-)
> ------------------------------------------------------------------------
>
> torture: Better summary diagnostics for build failures
>
> The reaction of kvm-recheck.sh is obscure at best, and easy to miss
> completely. This commit therefore prints "BUG: Build failed" in the
> summary at the end of a run.
>
> Signed-off-by: Paul E. McKenney <paulmck@linux.vnet.ibm.com>
next prev parent reply other threads:[~2014-03-18 8:51 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-16 1:59 cond_resched() and RCU CPU stall warnings Paul E. McKenney
2014-03-16 6:09 ` Mike Galbraith
2014-03-16 6:14 ` Mike Galbraith
2014-03-16 6:27 ` Paul E. McKenney
2014-03-16 6:25 ` Paul E. McKenney
2014-03-16 7:30 ` Mike Galbraith
2014-03-17 10:13 ` Peter Zijlstra
2014-03-17 16:58 ` Paul E. McKenney
2014-03-17 17:14 ` Peter Zijlstra
2014-03-18 2:17 ` Paul E. McKenney
2014-03-18 8:51 ` Peter Zijlstra [this message]
2014-03-18 12:49 ` Paul E. McKenney
2014-03-18 13:45 ` Peter Zijlstra
2014-03-18 15:15 ` Paul E. McKenney
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140318085118.GO25546@laptop.programming.kicks-ass.net \
--to=peterz@infradead.org \
--cc=josh@joshtriplett.org \
--cc=laijs@cn.fujitsu.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=paulmck@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox