The Linux Kernel Mailing List
 help / color / mirror / Atom feed
From: Simon Guinot <simon.guinot@sequanux.org>
To: Neil Brown <neilb@suse.de>
Cc: linux-raid@vger.kernel.org, linux-kernel@vger.kernel.org,
	"Rémi Rérolle" <remi.rerolle@seagate.com>
Subject: Re: [PATCH 0/2] md: fix fix deadlock while suspending RAID array
Date: Tue, 18 Mar 2014 15:48:51 +0100	[thread overview]
Message-ID: <20140318144850.GE14452@kw.sim.vm.gnt> (raw)
In-Reply-To: <1394565130-24233-1-git-send-email-simon.guinot@sequanux.org>


[-- Attachment #1.1: Type: text/plain, Size: 1568 bytes --]

On Tue, Mar 11, 2014 at 08:12:08PM +0100, Simon Guinot wrote:
> Hi,
> 
> This patch series fixes a deadlock which have been observed while
> updating a RAID array level, using the mdadm --grow command. A full
> description of the issue (hopefully understandable enough) is provided
> by the commit message in the second patch.
> 
> Please, let me know if this patches are correct and/or if there is an
> another way (maybe more handy) to solve this deadlock issue.

Hi Neil,

Please, let me know your feedback about this bug and the patches.

Additionally, you will find attached to this email a shell script which
allows to reproduce the deadlock (with most of the configurations).
Basically, this script creates some loopback devices on the top of files
(size 10MB) stored under /tmp. In an infinite loop, the loopback devices
are used to create a RAID1 array and then to migrate this last into a
RAID5 one. At some point, you should hit the deadlock.

Thanks,

Simon

> 
> Thanks,
> 
> Simon
> 
> Simon Guinot (2):
>   md: move up mddev locking functions
>   md: fix deadlock while suspending RAID array
> 
>  drivers/md/md.c | 154 ++++++++++++++++++++++++++++++--------------------------
>  1 file changed, 83 insertions(+), 71 deletions(-)
> 
> -- 
> 1.8.5.3
> 
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at  http://www.tux.org/lkml/

[-- Attachment #1.2: md-suspend-deadlock.sh --]
[-- Type: application/x-sh, Size: 2100 bytes --]

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 181 bytes --]

      parent reply	other threads:[~2014-03-18 15:12 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-03-11 19:12 [PATCH 0/2] md: fix fix deadlock while suspending RAID array Simon Guinot
2014-03-11 19:12 ` [PATCH 1/2] md: move up mddev locking functions Simon Guinot
2014-03-11 19:12 ` [PATCH 2/2] md: fix deadlock while suspending RAID array Simon Guinot
2014-03-19 23:02   ` NeilBrown
2014-03-18 14:48 ` Simon Guinot [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140318144850.GE14452@kw.sim.vm.gnt \
    --to=simon.guinot@sequanux.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-raid@vger.kernel.org \
    --cc=neilb@suse.de \
    --cc=remi.rerolle@seagate.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox