From: Daniel Vetter <daniel@ffwll.ch>
To: Steven Rostedt <rostedt@goodmis.org>
Cc: LKML <linux-kernel@vger.kernel.org>,
Daniel Vetter <daniel.vetter@ffwll.ch>,
Ben Widawsky <ben@bwidawsk.net>,
Chris Wilson <chris@chris-wilson.co.uk>,
Ramkumar Ramachandra <artagnon@gmail.com>,
Jiri Olsa <jolsa@redhat.com>,
Arnaldo Carvalho de Melo <acme@redhat.com>,
Namhyung Kim <namhyung@kernel.org>,
stable <stable@vger.kernel.org>
Subject: Re: [PATCH] drm/i915: Do not dereference pointers from ring buffer in evict event
Date: Tue, 18 Mar 2014 20:50:07 +0100 [thread overview]
Message-ID: <20140318195007.GJ30571@phenom.ffwll.local> (raw)
In-Reply-To: <20140318113136.02d2e08b@gandalf.local.home>
On Tue, Mar 18, 2014 at 11:31:36AM -0400, Steven Rostedt wrote:
> On Tue, 18 Mar 2014 11:27:37 -0400
> Steven Rostedt <rostedt@goodmis.org> wrote:
>
> > The TP_printk() should never dereference any pointers, because the ring
> > buffer can be read at some unknown time in the future. If a device no
> > longer exists, it can cause a kernel oops. This also makes this
> > event useless when saving the ring buffer in userspaces tools such as
> > perf and trace-cmd.
> >
> > The i915_gem_evict_vm dereferences the vm pointer which may also not
> > exist when the ring buffer is read sometime in the future.
> >
> > Link: http://lkml.kernel.org/r/1395095198-20034-3-git-send-email-artagnon@gmail.com
> > Reported-by: Ramkumar Ramachandra <artagnon@gmail.com> Cc:
> > stable@vger.kernel.org # 3.13+
>
> Bah, claw's mail is playing havoc with my line wraps. Please fix the
> above when applying, or I can send anothe patch. Thanks :-)
>
> I had to re-insert the patch due to it but didn't see the screw up with
> the Cc of stable.
Patch applied and cc: stable fixed, thanks.
-Daniel
--
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch
next prev parent reply other threads:[~2014-03-18 19:50 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-18 15:27 [PATCH] drm/i915: Do not dereference pointers from ring buffer in evict event Steven Rostedt
2014-03-18 15:31 ` Steven Rostedt
2014-03-18 19:50 ` Daniel Vetter [this message]
2014-03-19 1:25 ` [PATCH v2] " Steven Rostedt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140318195007.GJ30571@phenom.ffwll.local \
--to=daniel@ffwll.ch \
--cc=acme@redhat.com \
--cc=artagnon@gmail.com \
--cc=ben@bwidawsk.net \
--cc=chris@chris-wilson.co.uk \
--cc=daniel.vetter@ffwll.ch \
--cc=jolsa@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=namhyung@kernel.org \
--cc=rostedt@goodmis.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox