From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932791AbaCSIh1 (ORCPT ); Wed, 19 Mar 2014 04:37:27 -0400 Received: from mail-wi0-f177.google.com ([209.85.212.177]:36688 "EHLO mail-wi0-f177.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932595AbaCSIhX (ORCPT ); Wed, 19 Mar 2014 04:37:23 -0400 Date: Wed, 19 Mar 2014 08:37:18 +0000 From: Lee Jones To: Sachin Kamat Cc: Krzysztof Kozlowski , Sangbeom Kim , Samuel Ortiz , LKML Subject: Re: [PATCH] mfd: sec-core: Fix I2C dummy device resource leak on probe failure Message-ID: <20140319083718.GA31687@lee--X1> References: <1395147470-24817-1-git-send-email-k.kozlowski@samsung.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > On 18 March 2014 18:27, Krzysztof Kozlowski wrote: > > Dummy I2C device allocated in sec_pmic_probe() leaked if > > devm_regmap_init_i2c() failed. Unregister it before returning from > > probe. > > > > Signed-off-by: Krzysztof Kozlowski > > Looks good. > Reviewed-by: Sachin Kamat Applied with Sachin's Ack. -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog