Re: [PATCH 4/4] perf/x86/uncore: modularize Intel uncore driver

[Ingo Molnar <mingo@kernel.org>]

* Peter Zijlstra <peterz@infradead.org> wrote:

> On Wed, Mar 19, 2014 at 12:32:54PM +0100, Ingo Molnar wrote:
> > 
> > * Peter Zijlstra <peterz@infradead.org> wrote:
> > 
> > > On Tue, Mar 18, 2014 at 04:56:44PM +0800, Yan, Zheng wrote:
> > > > This patch adds support for building Intel uncore driver as module.
> > > > It adds clean-up code and config option for the Intel uncore driver
> > > > 
> > > > Signed-off-by: Yan, Zheng <zheng.z.yan@intel.com>
> > > > ---
> > > >  arch/x86/Kconfig                              |  7 ++++
> > > >  arch/x86/configs/i386_defconfig               |  1 +
> > > >  arch/x86/configs/x86_64_defconfig             |  1 +
> > > >  arch/x86/kernel/cpu/Makefile                  |  3 +-
> > > >  arch/x86/kernel/cpu/perf_event_intel_uncore.c | 48 ++++++++++++++++++++++++---
> > > >  5 files changed, 55 insertions(+), 5 deletions(-)
> > > > 
> > > > diff --git a/arch/x86/Kconfig b/arch/x86/Kconfig
> > > > index 0af5250..8e4e247 100644
> > > > --- a/arch/x86/Kconfig
> > > > +++ b/arch/x86/Kconfig
> > > > @@ -1103,6 +1103,13 @@ config X86_CPUID
> > > >  	  with major 203 and minors 0 to 31 for /dev/cpu/0/cpuid to
> > > >  	  /dev/cpu/31/cpuid.
> > > >  
> > > > +config X86_INTEL_UNCORE
> > > > +	tristate "Intel uncore performance monitoring support"
> > > > +	depends on CPU_SUP_INTEL
> > > > +	---help---
> > > > +	  This adds a driver to access the Uncore performance monitoring Units
> > > > +	  of Intel processors.
> > > > +
> > > 
> > > Ingo do you agree with this config option placement?
> > 
> > Yeah, the modularization looks mostly good to me, but its name 
> > should lie within the PERF namespace, i.e. 
> > CONFIG_PERF_PMU_X86_INTEL_UNCORE=y.
> 
> Ah; but do you want this config option hidden in the "Processor type 
> and features" menu or would they be better in "General setup/Kernel 
> Performance Events and Counters" ?

What's your preference? There's a vali argument for both: the uncore 
driver is part of the CPU, but it's also a perf driver.

Thanks,

	Ingo