From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S964992AbaCSMrb (ORCPT ); Wed, 19 Mar 2014 08:47:31 -0400 Received: from mail-wi0-f181.google.com ([209.85.212.181]:44700 "EHLO mail-wi0-f181.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933597AbaCSMra (ORCPT ); Wed, 19 Mar 2014 08:47:30 -0400 Date: Wed, 19 Mar 2014 12:47:20 +0000 From: Lee Jones To: Krzysztof Kozlowski Cc: Sangbeom Kim , Samuel Ortiz , Alessandro Zummo , linux-kernel@vger.kernel.org, rtc-linux@googlegroups.com, Sachin Kamat , Kyungmin Park , Bartlomiej Zolnierkiewicz , Tomasz Figa Subject: Re: [PATCH-next] mfd/rtc: s5m: Do not allocate RTC I2C dummy and regmap for unsupported chipsets Message-ID: <20140319124720.GH31687@lee--X1> References: <1395232095-7103-1-git-send-email-k.kozlowski@samsung.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1395232095-7103-1-git-send-email-k.kozlowski@samsung.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > The rtc-s5m driver does not support all of S2M and S5M chipsets > supported by main MFD sec-core driver. For such chipsets unsupported by > rtc-s5m, the MFD sec-core driver initialized regmap with default config. > This config in such cases wouldn't work at all. > > The main MFD sec-core driver shouldn't initialize regmap for child > drivers which is not used by them and even not valid. > > Move the allocation of RTC I2C dummy device and initialization of RTC > regmap from main MFD sec-core driver to the rtc-s5m driver. The rtc-s5m > driver will use proper regmap config for supported devices. > > Signed-off-by: Krzysztof Kozlowski > --- > drivers/mfd/sec-core.c | 53 +-------------------------- > drivers/rtc/rtc-s5m.c | 75 +++++++++++++++++++++++++++++++++++--- > include/linux/mfd/samsung/core.h | 3 -- > 3 files changed, 71 insertions(+), 60 deletions(-) It's a bit late in the cycle for this kind of change. Would you mind re-sending after the v3.15 merge window please? -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog